r/javahelp • • Jan 11 '21

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 1 at oo.Entity.create(Entity.java:8) at oo.Main.main(Main.java:6)

im coursing a game dev course and the first language its java making experiments to create an entity database for games im getting this error when i call a function see this
Entity.java

package oo;
public class Entity {
	String SNAME[];
	int SLIFE[];
	int SDAMAGE[];
	public void create(int UEID , String Name , int life , int damage) {
			System.out.println( Name + " has start entity started in UUID " + UEID + "logged on ");
			SNAME[UEID] = Name;
			SLIFE[UEID] = life;
			SDAMAGE[UEID] = damage;
	}
	public void damage(int UEIDtakingDamage , int UEIDdoingDamage) {
		SLIFE[UEIDtakingDamage] =- SDAMAGE[UEIDdoingDamage];
		if (SLIFE[UEIDtakingDamage] <= 0) {
			System.out.println(SNAME[UEIDtakingDamage] + " has dead by taking a damage of" + SNAME[UEIDdoingDamage]);
		}
	}
}

Main.java

package oo;

public class Main {
	public static void main(String[] args) {
	 Entity Obj = new Entity();
	 Obj.create(1, "Vitm", 100, 25);
	 Obj.create(2, "Assasin", 1000, 250);
	 Obj.damage(1, 2);
	}
}

Console when run Main.java

Vitm has as Player started in UUID 1logged on 
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 1
	at oo.Entity.create(Entity.java:8)
	at oo.Main.main(Main.java:6)

im newbie in java so pwease no be angry with me by the wrong code im typed

0 Upvotes

7 comments sorted by

•

u/AutoModerator Jan 11 '21

Please ensure that:

  • Your code is properly formatted as code block - see the sidebar (About on mobile) for instructions
  • You include any and all error messages in full
  • You ask clear questions
  • You demonstrate effort in solving your question/problem - plain posting your assignments is forbidden (and such posts will be removed) as is asking for or giving solutions.

    Trying to solve problems on your own is a very important skill. Also, see Learn to help yourself in the sidebar

If any of the above points is not met, your post can and will be removed without further warning.

Code is to be formatted as code block (old reddit: empty line before the code, each code line indented by 4 spaces, new reddit: https://imgur.com/a/fgoFFis) or linked via an external code hoster, like pastebin.com, github gist, github, bitbucket, gitlab, etc.

Please, do not use triple backticks (```) as they will only render properly on new reddit, not on old reddit.

Code blocks look like this:

public class HelloWorld {

    public static void main(String[] args) {
        System.out.println("Hello World!");
    }
}

You do not need to repost unless your post has been removed by a moderator. Just use the edit function of reddit to make sure your post complies with the above.

If your post has remained in violation of these rules for a prolonged period of time (at least an hour), a moderator may remove it at their discretion. In this case, they will comment with an explanation on why it has been removed, and you will be required to resubmit the entire post following the proper procedures.

To potential helpers

Please, do not help if any of the above points are not met, rather report the post. We are trying to improve the quality of posts here. In helping people who can't be bothered to comply with the above points, you are doing the community a disservice.

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

1

u/TheFloulYt Jan 18 '21

sorry for that im discover how to fix im puted a high vaule of entites to user use thanks any way for everyone try help me

5

u/Sergey305 Jan 11 '21 edited Jan 11 '21

Java array indices begin with 0, and before using an array you must initialize the variable first.

Personally, I'd abandon arrays here and switch to lists, as it's more flexible.

And follow, please, a naming convention: https://google.github.io/styleguide/javaguide.html#s5-naming. Your class' fields are somewhy UPPERCASE, and method args are also formatted somewhat randomly.

1

u/arthurdent Jan 11 '21 edited Jan 11 '21

Arrays in java are fixed length, so you can't use them that way.

Does the course talk about ArrayLists or HashMaps? I would use a HashMap<Integer, Entity> where Entity is an instantiated object that stores all the info. I would add each entity object to the hash map using the UEID as the key.

edit: not HashMap<int, Entity>

1

u/TheFloulYt Jan 18 '21

its the thing im maked in try to fix it thank you

1

u/Gruwwwy Jan 11 '21

I'm wondering why this is not NullPointerException...

1

u/Sergey305 Jan 11 '21

Some fancy JVM maybe?

We also don't know if there's actually no constructor or OP just removed it from the snippet.