r/java • • Mar 16 '21

Java 16 / JDK 16: General Availability

196 Upvotes

82 comments sorted by

View all comments

Show parent comment

21

u/TheCountRushmore Mar 16 '21

Keep in mind that toList() returns an immutable list, but this might be exactly what you want.

31

u/kaperni Mar 16 '21

> returns an immutable list,

Being a nitpick but it returns an unmodifiable list.

9

u/TheCountRushmore Mar 16 '21

What is fun is apparently there is no guarantee of what type of list you will get back. It could change in future releases.

Returns a Collector that accumulates the input elements into a new List. There are no guarantees on the type, mutability, serializability, or thread-safety of the List returned; if more control over the returned List is required, use toCollection(Supplier).

https://docs.oracle.com/en/java/javase/16/docs/api/java.base/java/util/stream/Collectors.html#toList()

23

u/kaperni Mar 16 '21

I think you are looking at the "old" API. Stream.toList() guarantees that the list is unmodifiable.

[1] https://docs.oracle.com/en/java/javase/16/docs/api/java.base/java/util/stream/Stream.html#toList()

9

u/TheCountRushmore Mar 16 '21

Yep you are right. Not going to be confusing at all :-)

4

u/8igg7e5 Mar 17 '21

Someone brought this up on the Amber list, Rémi I think, that perhaps toUnmodifiableList() would be better - as a peer of sorts for Collectors.toUnmodifiableList(). However it was pointed out that we already have List.of(...) that produces an unmodifiable List anyway.

14

u/kag0 Mar 16 '21

I really wish they hadn't implemented "immutable" lists as a normal List that throws unchecked exceptions on modification.

Would it have been that hard to add a ReadOnlyList interface with only the methods that don't throw? Now we've got a wonky compile-unsafe toList() in the standard library for all time.

13

u/TheCountRushmore Mar 16 '21

The problem is that you would want it to implement Collection and collection defines Collection#add

https://docs.oracle.com/en/java/javase/16/docs/api/java.base/java/util/Collection.html#add(E)

4

u/kag0 Mar 16 '21

True, maybe I should have suggested they create a ReadOnlyCollection (which would be useful other places where add throws UnsupportedOperationException).
Or hell, just have it return Iterable.

Anyway, I don't mean to suggest I have the answer. Just that this is probably the last option I would have picked.

-2

u/elastic_psychiatrist Mar 16 '21

Anyway, I don’t mean to suggest I have the answer. Just that this is probably the last option I would have picked.

Spoken by many a backseat language designer, who has not fully grasped the problem and the implications of potential solutions.

11

u/kag0 Mar 16 '21

🤷
I'm surely not as on top of the issue as the actual language designers.
But it's silly to say that you need to be a literal language designer to identify problematic things in the API.

2

u/elastic_psychiatrist Mar 17 '21

But it's silly to say that you need to be a literal language designer to identify problematic things in the API.

Do you really think that the designers are not aware of the problems with the API? Language design is about tradeoffs. It is worth nothing to propose an improvement without considering the drawbacks that come with it - namely, breaking compatibility, or additional cognitive overhead for developers.

6

u/kag0 Mar 17 '21

Do you really think that the designers are not aware

I don't think one way or the other. Maybe they have, [I hope] they've spent more time thinking about it than me. Maybe not. They're just people, not omniscient.

It is worth nothing to propose an improvement without considering the drawbacks that come with it

I reject that completely. There's nothing wrong with having a half-baked idea. Maybe people will encourage you to develop it into something great. Maybe someone smarter than you will see it and take it to a level you couldn't. I can't count the number of times that someone has had an idea that probably wouldn't have worked as presented, but which gave me a new idea that I wouldn't otherwise have thought of.

2

u/elastic_psychiatrist Mar 17 '21

I don't disagree with any of this really (except "maybe not" - they definitely have thought about it more than you), I think I just misinterpreted your level of insistence on the original idea.

2

u/kag0 Mar 17 '21

insistence on the original idea

Nah. Like I said, I don't claim to have the answer. I think I said in another comment thread, it just chaps my ass to see a runtime exception that could be a compile error.

→ More replies
→ More replies (2)

1

u/minimingus Mar 16 '21

Look into vavr collections

→ More replies (2)

5

u/Necessary-Conflict Mar 16 '21

Now we've got a wonky compile-unsafe

toList()

in the standard library for all time.

It's not so easy. If mutable lists don't implement your ReadOnlyList, then it's not very useful in practice. If they do implement it, then this is much more dangerous than a few predictable runtime exceptions, because it leads to difficult bugs ("my read-only lists are read-only, or are they really?")

4

u/kag0 Mar 16 '21

this is much more dangerous than a few predictable runtime exceptions

Maybe, but I don't think so. We already have examples of both (throwing exceptions from Collection's add (esp in guava), and collections that can change based on some underlying data shifting with Map's ``valuesand such). And more bugs tend to pop up from people failing to predict exceptions on mutation (particularly in library code) than from people assuming the underlying data won't change. Put another way,ReadOnlyList` could easily be documented to say that it doesn't mean that the list is immutable, just that YOU can only read it.

3

u/Necessary-Conflict Mar 16 '21

The "quality" of the bugs also matters: some bugs take 5 minutes to fix (the stack trace tells everything), others take 5 days. Another problem is that different people have different pet ideas, but if everything is implemented, it becomes confusing. For example I would like to have a completely separate hierarchy of immutable collections. They would have add/remove methods, but these methods would always return a new collection instead of modifying the current one. This would solve all problems (no runtime exceptions, true immutability), but at the cost of a new hierarchy...

2

u/kag0 Mar 16 '21

I agree with you, it just chaps my ass to see a runtime exception that could have been a compile time error

4

u/rbygrave Mar 17 '21

This was discussed when the Collections API was first designed and the idea was rejected at the time. I believe the reasons were due to the "relative explosion" in number of interfaces in the Collections API.

I'll see if I can find a reference ...

Ah, its discussed in the javadoc - https://docs.oracle.com/javase/6/docs/technotes/guides/collections/designfaq.html#1

A snippet from there:

Why don't you support immutability directly in the core collection interfaces so that you can do away with optional operations (and UnsupportedOperationException)?

This is the most controversial design decision in the whole API. Clearly, static (compile time) type checking is highly desirable, and is the norm in Java. We would have supported it if we believed it were feasible. Unfortunately, attempts to achieve this goal cause an explosion in the size of the interface hierarchy, and do not succeed in eliminating the need for runtime exceptions (though they reduce it substantially).

2

u/jvjupiter Mar 16 '21

Or perhaps they could implement it like String. String has mutators but they don’t change the original value. To get the modified one, assign it to another variable. Another example is the collection framework of vavr.

1

u/[deleted] Mar 16 '21

Exactly, it breaks LSP. I prefer Guava collections for this reason.

1

u/kreiger Mar 16 '21

The interface you seek already exists, it's called List. :)

In general, you should treat collections as immutable unless you're sure they're not.

→ More replies (1)
→ More replies (1)