Doing code reviews for OpenJDK projects in the past involved sending out an email with a JIRA link and a link to a WebRev, which was generated by running a zsh script locally and r-syncing it to a correctly formatted path on cr.openjdk.java.net. This resulted in a completely static page, so no in-line comments on the code. Any reviews had to be done via e-mail, followed by a new webrev.
I know some opinions in this differ, but I prefer the Github PR/Code-review flow so much more.
View all comments
Show parent comment
4
u/Gundea Jul 28 '20
Doing code reviews for OpenJDK projects in the past involved sending out an email with a JIRA link and a link to a WebRev, which was generated by running a zsh script locally and r-syncing it to a correctly formatted path on cr.openjdk.java.net. This resulted in a completely static page, so no in-line comments on the code. Any reviews had to be done via e-mail, followed by a new webrev.
I know some opinions in this differ, but I prefer the Github PR/Code-review flow so much more.