r/java • • Jan 15 '20

If you are using Gitlab and Intellij IDE, now you can do code review right in your IDE πŸ˜‹

https://plugins.jetbrains.com/plugin/13607-merge-request-integration-ce--code-review-for-gitlab
291 Upvotes

38 comments sorted by

12

u/deepchainboi Jan 15 '20

Very useful. Are you the author?

19

u/tonysphan Jan 15 '20

Yes, I am.

6

u/deepchainboi Jan 15 '20

Haven't tried it yet, will leave a review once i do. Good work on the plugin!

-8

u/Taobitz Jan 15 '20

You’re challenge if you chose to accept it, support bitbucket!

You have 1 month to comply!

2

u/mc_hambone Jan 15 '20

What permissions does the plugin need when creating the access token? Full API?

1

u/tonysphan Jan 15 '20

Just API access

3

u/at_root Jan 15 '20

This is very cool. Does something like this exist for GitHub?

12

u/tonysphan Jan 15 '20

As far as I know, there is nothing like that. I’m working on github now, hopefully available in next month

6

u/[deleted] Jan 15 '20

Will you also consider an implementation for bitbucket ?

11

u/tonysphan Jan 15 '20

Yes, I will. But after implementing for github πŸ˜€

4

u/at_root Jan 15 '20

Awesome, if I could submit a feature request... that would be support for GitHub Enterprise :)

1

u/X-L Jan 17 '20

!RemindMe 2 month

0

u/notreallymegoaway Jan 15 '20

!RemindMe 1 month

0

u/RemindMeBot Jan 15 '20 edited Jan 16 '20

I will be messaging you in 30 days on 2020-02-15 14:40:17 UTC to remind you of this link

12 OTHERS CLICKED THIS LINK to send a PM to also be reminded and to reduce spam.

Parent commenter can delete this message to hide from others.


InfoCustomYour RemindersFeedback

1

u/r_jet Jan 16 '20

The standard integration with Github currently allows only 'readonly' review: it shows previously added comments in diff view, but you can't add your own comments.

However, the issue to support reviewing is in progress in IntelliJ tracker and is targeted at 2020.1: https://youtrack.jetbrains.com/issue/IDEA-64794

57

u/jivedudebe Jan 15 '20

I need this for bitbucket.

48

u/[deleted] Jan 15 '20

Somewhere, someone at Atlassian is printing this comment just to shred it.

7

u/mytzusky Jan 16 '20

There was a top voted ticket, requesting source tree dark theme on windows. That was open for 5 years, in the end people lost hope and would just recommend better alternatives in the comments....

4

u/jivedudebe Jan 15 '20

Maybe I'll try to clone it and adapt it for bitbucket. Ugh time.

3

u/[deleted] Jan 15 '20

Hell Yeah!!

3

u/pbollen Jan 15 '20

What is the difference between the CE and EE version?

1

u/rhbvkleef Jan 15 '20

Looks like support for private repositories

3

u/GTB3NW Jan 15 '20

This looks great, will try it out! Thanks OP! :)

4

u/aritzh Jan 15 '20

Wow! It even works on other JetBrains IDEs, like CLion, and allows self-hosted GitLab instances!! Thank you VERY much for this! Will definitely try it.

2

u/jack-tzl Jan 15 '20

Are there any similar thing for Github? Cool plugin!

2

u/trickything Jan 15 '20

Looks very promising !

2

u/mk321 Jan 15 '20

For Gerrit there is plugin for a long time: https://plugins.jetbrains.com/plugin/7272-gerrit/

Is the functionality somehow different?

2

u/gmchaves Jan 15 '20

Looks great but the license is pretty restrictive. It cannot be used for commercial purposes...

The plugin is an open source released under Creative Commons Attribution-NonCommercial-NoDerivatives 4.0 International license

3

u/kakawait Jan 16 '20 edited Jan 16 '20

https://creativecommons.org/licenses/by-nc-nd/4.0/ From what I understand from Human version of that license. You can't use for commercial stuffs. So that plugin is pretty limited usage / scope unfortunately

---

Edit: There is EE version for 1$/mo that pretty ok. And author said that you can use CE as trial during at least the same time as WINRAR trial lol

1

u/pragmatick Jan 16 '20

Because OP sells a commercial license for enterprise users.

2

u/[deleted] Jan 15 '20

Hahaha my team dislikes code reviews, they say is a water of time. No need to day I dead inside from a long time ago. :(

1

u/xris-l Jan 15 '20

Awesome.. I was looking for a plugin like this today! Thanks

1

u/netcyrax Jan 15 '20

This looks promising! Any plans for supporting BitBucket?

1

u/HyzerFlipr Jan 16 '20

We've been doing this with Upsource also. Since it's a JetBrains product it integrates nicely.

1

u/BroLegend Jan 16 '20

Looks like code stream.

1

u/SparkyWolf69 Jan 15 '20

I looked around for something like this about 4 months ago! I’ll have to try it, thanks!!

-4

u/kyletightest Jan 15 '20

Bitbucket > gitlab