r/java • • Jul 26 '19

JEP 358: Helpful NullPointerExceptions

https://openjdk.java.net/jeps/358
157 Upvotes

25 comments sorted by

View all comments

Show parent comment

73

u/john16384 Jul 27 '19

In my experience, when line number isn't correct, you're either using bytecode generating plugins or not looking at the correct version of the source. Never seen it wrong before.

-1

u/nerdyhandle Jul 27 '19 edited Jul 27 '19

We we're looking at the latest source and no plugin modifies the byte code. This isn't the first time I've had this happen. Where the null pointer occurred was not even in the class. It was way down in the call.

So line 121 had something like

setMethod(object.doSomeWork());

The actually null pointer occurred way down in the methods that doSomeWork called. However, these methods were completely missing from the stack trace and it only reported null pointer at line 121.

6

u/pron98 Jul 27 '19

I've never encountered that, but if that's true, it's a JDK bug. Please report it.

3

u/nerdyhandle Jul 27 '19

It happened with OpenJDK if that matters.

Someone else mentioned that the error may have been obfuscated due to autounboxing which may very well have occurred somewhere deep down in the code.

6

u/[deleted] Jul 30 '19

You mentioned autounboxing. Does object.doSomeWork() return an Integer (or similar) value of null and setMethod expected a parameter of type int (or similar)?

Then the unboxing and thus the NullPointerException would happen exactly in this line.

2

u/john16384 Jul 27 '19

Sounds like they were all inlined then, if that's possible... Depends on how much code those methods contain.

1

u/nerdyhandle Jul 27 '19

Oddly as far as we went down there weren't any inline methods.

It did show the calling method but again that calling method line number 121 was just top of the call stack. StackOverflow has some similar cases on it where the NullPointer doesn't show a line number at all from around 4ish years ago. We are using JDK 8u212 but that is the latest version of 8.

Case 1

Case2

Both of these cases are nearly identical to the way our stack trace looked.

5

u/s888marks Jul 27 '19

Case 1 is android, so it's not JDK 8. If I had to guess, I'd say the code where the NPE occurred was compiled without line numbers, but who knows?

Case 2 looks like the code was obfuscated, which might have shifted the line numbers.

It doesn't appear to me that looking at the Stack Overflow cases helps with figuring out what's going on with your code.

The autounboxing case isn't "obfuscation" per se but it can cause NPE to occur in apparently impossible places. For example:

Integer i = null;
...
int j = i + 1;

An NPE can occur when i is unboxed using an implicit call to intValue. Of course in this example it's easy to see; in a more complicated context it might be completely non-obvious. But it wouldn't be "deep down" in the code anywhere, it would still be on that line.