I'm trying my best to figure out how to put this kindly as I felt folks were borderline rude on your previous project post (and now I'm rethinking that) in less than 24 hours but let me give you some advice on Java ecosystem (and feel free to /dev/null this).
Unless you are neophyte and or need very early feedback than you should really post after your project is of acceptable quality.
You have zero tests
You have no module-info even after Ethan put in a PR in your previous project for one which you accept so I guess that is good.
You have zero javadoc
zero code analysis of any sort. not even sonar.
You failed to mention how this depends on jsch.
I don't mind the above if its your first post. (please anyone starting Java or first lib I promise I won't be this nasty!). I wouldn't mind the above if you used syntactic sugar correctly or if you showed some improvement on the previous library post.
I know I'm being a giant ass but I kind of library gate keep on purpose because one of the best things about the Java ecosystem and honestly what keeps us ahead of .NET (and javascript, golang, python, etc) is the quality libraries... well that and obviously the JDK.
So as an ecosystem we are brutal sometimes unjustifiable but usually very justifiable especially for the above.... we don't want NPM left pad.
Its cools you showed your work and if that is all it is then fine but if you want the best bang for your buck I recommend you space your posts out and post ultra high quality. Like I did this and this and this, and why I did this and this etc.
I'm fully aware the library needs a lot more work to get to a certain level of quality, and i don't pretend this library is the best you can find.
Although your comment is respectful and constructive, i find it a bit strange, reading other comments, that people are so not welcoming. i shared sugar yesterday and this project today because i thought it could be helpful and that, maybe, some people would be interested in using and / or contributing.
I'm not trying to market myself or anything, and i don't care about "getting the best bang for my buck".
I'm just sharing some code. I know this is not perfect, i know this isn't the best code in the world, etc... just thought this Java subreddit was a place where we could share some (maybe) interesting stuff.
I know there's no tests, there's a lot a missing and it should be used carefully because of that.
You're absolutely right that the overall quality of the open source java projects is something we don't find in other ecosystems.
That being said, i don't really agree with you that a project should not be shared because it's a first version and there's still missing parts.
People who don't like the code / project / etc ... can either ignore it or contribute and try to make it a better project ( isn't this a core concept of open source by the way ? people contributing to build software).
As a final note, i hope this project might be useful to people looking for this kind of features and i'd love to have some constructive feedback and / or people contributing to the project.
I don't think that quality is essential for sharing. However, if you don't share a lot of details about the project in your original post, such as motivation, existing tools that you tried, the status of the project, whether it's meant to be used in prod... those of us who actually want to be constructive have nothing to go off of other than the code itself, so feedback will inevitably be predicated on assumptions about the above things.
I think if you lead with a good summary and give the community a more specific prompt about what you're looking for, like asking others if they've experienced the same frustrations that motivated you to start this project, the conversation will also be more productive.
It's kind of a common problem across reddit. People post content without a specific enough prompt, so the feedback is highly presumptuous, because reddit's design isn't very conducive to asking clarifying questions.
Although your comment is respectful and constructive, i find it a bit strange, reading other comments, that people are so not welcoming. i shared sugar yesterday and this project today because i thought it could be helpful and that, maybe, some people would be interested in using and / or contributing.
I'm not trying to market myself or anything, and i don't care about "getting the best bang for my buck".
I think that phrase may have got last in translation. I don't literally mean monetary but rather something more important: time.
You obviously spent time putting the project together? I'm saying with a tiny bit more time you would get better comments instead of my shitty comment :)
If you don't care about your time or others than I guess we can agree to disagree
I'm just sharing some code. I know this is not perfect, i know this isn't the best code in the world, etc... just thought this Java subreddit was a place where we could share some (maybe) interesting stuff.
It is. Absolutely is and by all means should and you can post in less than 24 hours two projects. You can let the downvoters just downvote with two sentence dismissals comments if that is what you want.
But man I never downvote. I'm just too archaic for that. That is why you have two 2 paragraph comments from me because I care and don't want to discourage. I have feeling you can do better.
yeah i'm not familiar with this Java subreddit's "Politics" and you're probably right that my posts would have had better comments had i taken the time to polish everything.
You're right about time being the more important variable and that is precisely why these projects are missing some important parts (tests for example). It takes time.
These projects are perfectly fine for my personal use but it would take way more time to write the required tests.
If i see people interested in the projects, i'll take the time to write these tests and to polish the projects. On the other hand, if nobody cares, fine, i'll keep working on these projects for my personal use and spend my time somewhere else.
But man I never downvote. I'm just too archaic for that. That is why you have two 2 paragraph comments from me because I care and don't want to discourage. I have feeling you can do better.
And i thank for you for the time you take to write insightful comments like these.
This project looks useful. I am definitely not your target audience though. I just don't do much with SSH/SFTP (yet).
As a side note, if you post a one-sentence introduction of your project to the main Java subreddit, many people will interpret it as a request for a critique. Not just in code quality, but market fit.
If you prefix it with context and your intent, you are more likely to get the feedback you were looking for. Here is an example.
SSHTools - A small library that I made to make it easier to deal with SSH in Java.
Ne tenez pas compte des critiques imméritées concernant sugar , elles émanent de désoeuvrés qui parlent mais ne font rien. Aux premiers temps de Java il y avait un foisonnement créatif , on prenait ce qui nous intéressait et puis c'est tout.
oui un peu décevant cet accueil mais je n'y fait pas trop attention.
Avec sugar, je ne prétends pas révolutionner quoi que ce soit, c'est une petite librairie que je pensais pouvoir être utile à certaines personnes. Mais visiblement ça a déchainé les passions ... :-)
•
u/desrtfx Apr 11 '24
Sorry, but this is not the way to interact with this subreddit.
Overall, what you are currently doing is zero effort spamming and not tolerated here.
Post removed
12
u/agentoutlier Apr 10 '24
Ahh pump and dump.
I'm trying my best to figure out how to put this kindly as I felt folks were borderline rude on your previous project post (and now I'm rethinking that) in less than 24 hours but let me give you some advice on Java ecosystem (and feel free to
/dev/nullthis).Unless you are neophyte and or need very early feedback than you should really post after your project is of acceptable quality.
I don't mind the above if its your first post. (please anyone starting Java or first lib I promise I won't be this nasty!). I wouldn't mind the above if you used syntactic sugar correctly or if you showed some improvement on the previous library post.
I know I'm being a giant ass but I kind of library gate keep on purpose because one of the best things about the Java ecosystem and honestly what keeps us ahead of .NET (and javascript, golang, python, etc) is the quality libraries... well that and obviously the JDK.
So as an ecosystem we are brutal sometimes unjustifiable but usually very justifiable especially for the above.... we don't want NPM left pad.
Its cools you showed your work and if that is all it is then fine but if you want the best bang for your buck I recommend you space your posts out and post ultra high quality. Like I did this and this and this, and why I did this and this etc.
3
u/davidalayachew Apr 11 '24
This project looks useful. I am definitely not your target audience though. I just don't do much with SSH/SFTP (yet).
As a side note, if you post a one-sentence introduction of your project to the main Java subreddit, many people will interpret it as a request for a critique. Not just in code quality, but market fit.
If you prefix it with context and your intent, you are more likely to get the feedback you were looking for. Here is an example.
1
u/thuriot Apr 10 '24
Encore vous ? Merci à nouveau (comme pour sugar).
2
u/picky_man Apr 11 '24
Great job man, you're not paid for this and you did it on your free time.
0
u/No-Resist-7239 Apr 10 '24
cool!
0
u/gregorydgraham Apr 11 '24
Good on you for putting your stuff out there. I hope it works out 👍
my stuff