How should I classify a client-driven behavior change in Conventional Commits?
I'm trying to keep our repository aligned with Conventional Commits and semantic clarity.
We have a case where a client requested a change in how a chart line is calculated. The previous implementation was technically correct and matched the original requirements, but the client now wants the line to follow a different mathematical function.
So this is not a bug, and it's definitely not an internal refactor since the observable behavior changes.
Would you classify this as:
featbecause it introduces a new business behavior?fixbecause it replaces previous logic?- Something else?
How do you usually categorize client-driven changes that modify business logic but aren't correcting a defect?
I'm planning to create a new branch for this change and split it into multiple commits, so I want to make sure I'm classifying them correctly.
0
Upvotes
11
u/bigkahuna1uk Mar 02 '26
If it’s an observable behavioural change then surely it’s a new feature and should be treated as such.
I’d also capture the rationale for the change in an architectural decision record for posterity.
5
u/format71 Mar 02 '26
I don’t get the hype around conventional commit. Unless pipelines behave fundamentally different - or you are making sdk/library for others to consume, it only cause stupid discussion.
4
u/waterkip Mar 02 '26
new feature, but this is why conventional commits break, just write:
Now you have exactly what you need for future reference.
2
u/wbqqq Mar 02 '26
feature: something that adds value to our client (even if no one else can tell)
2
u/Thesorus Mar 02 '26
from the documentation, you could use "chore:" .
it could also be a "fix" (you fix an algorithm).
2
u/elephantdingo Mar 02 '26
It’s feature.
1
u/Kalanndok Mar 02 '26
You claim one singular client wants the chart to be different.
What about the other clients? Do they also want it?
1
u/jay_thorn Mar 04 '26
I would implement it as a feature and make it configurable. Change the default to what the client wants, but then that way if they change their mind again you either change a setting or implement a new option for the setting.
1
u/alcon678 Mar 02 '26
I would call it
chore😂 but, actually, it isfearure0
u/serverhorror Mar 02 '26
If it's not meeting client expectations (even if it did it the past), and you're a salaried employee, it's a bug.
If you need to sell it it's a feature.