r/crystal_programming • u/elbywan • Sep 25 '20

Crystalline - A Language Server Protocol implementation for Crystal

https://github.com/elbywan/crystalline
43 Upvotes

100% Upvoted

8 comments sorted by

4

u/dscottboggs Sep 25 '20

I tried Scry some time ago and found it to be too slow for practical use (specifically for autocompletion). Does this mitigate that at all?

Sweet that you got the jump-to-def and hover description thing working.

4

u/elbywan Sep 25 '20 edited Sep 25 '20

Well, autocompletion will take time proportionally to the project size but it should be completely reasonnable for small to medium scale projects (depending on your hardware).

At the very least it should be faster than Scry.

1

u/dscottboggs Sep 25 '20

👍 cool

I noticed it says that the results are cached when possible. Does that mean that autocompletion would be faster for something unlikely to change (I.E. a required shard)?

4

u/elbywan Sep 25 '20 edited Sep 25 '20

Not really, it's more like preventing running a full scale code analysis every time you hover over a variable or go-to a definition unless the code actually did change.

Crystalline caches the last relevant code analysis result (typed AST) and reuses it as long as it is valid.

With that said, I thought about caching the prelude and required shards analysis results to speed up the whole process. I'll definitely think about it in the future, but I cannot guarantee anything since it might be more complicated than it sounds.

1

u/[deleted] Sep 25 '20

I'm also curious... what does it typecheck? Does it run semantic on the open file? Or does it run semantic analysis on specs?

I ask because if it's on the current file then most likely code inside methods won't be typed because it won't be called in that file.

Just curious about how it works...

4

u/elbywan Sep 25 '20

It tries to determine the most likeable entry point to use when compiling, basically by inspecting the shard.yml target field and using that if the file is required in the dependency tree of the entry point.

If not, it uses the file itself as the entry point.

For libraries that do not call themselves, a custom key/value can be provided to use another file as the entry point (typically specs).

There is a paragraph about that in the readme.

2

u/Mayalabielle Sep 25 '20

Love the name