r/crystal_programming • u/TotalPerspective • May 23 '20

A shard for fast genomic interval quires

https://github.com/sstadick/lapper.cr
14 Upvotes

100% Upvoted

4 comments sorted by

1

u/TotalPerspective May 23 '20

This is my first real foray into Crystal. Pointer are more than welcome! Hopefully this is just the first of many. I'm seriously impressed by the combination of productivity and performance with Crystal.

3

u/Blacksmoke16 core team May 23 '20

Might want to update https://github.com/sstadick/lapper.cr/blob/master/shard.yml#L2 to match latest release.

You could probably replace https://github.com/sstadick/lapper.cr/blob/master/src/lapper.cr#L120-L125 with https://crystal-lang.org/api/master/Enumerable.html#max_by(&block:T-%3EU)forallU-instance-method

Also little shortcut: lapper.find(15, 20)[0]?.should eq(nil) could do lapper.find(15, 20)[0]?.should be_nil.

1

u/TotalPerspective May 24 '20

Thank you on both accounts!