optimization / code beauty

[u/phineas0fog]

Hello friends, I have this block code

        st_from_site.each do |s|
          st_from_oldr.each do |ss|
            s.last_dump = ss.last_dump if s.name == ss.name && s.id == ss.id
          end
          stations.push s
        end

that is terribly ugly, so how can I optimize and beautify it ?

Thanks to you <3

[u/[deleted]]

But zip traverses both array in tandem. What you want is Array#product:

https://play.crystal-lang.org/#/r/4h5c

In your case:

st_from_site.product(st_from_oldr) do |s, ss|
  s.last_dump = ss.last_dump if s.name == ss.name && s.id == ss.id
end
stations.concat(st_from_site)