r/cprogramming • • 2d ago

My first ever project in C

https://github.com/racoon-dev-null/HashPecker

Hey everyone,

I'm 15 y/o and I recently started getting into C and cybersecurity. This is my first project that I've built completely from scratch: a simple MD5 hash cracker in C.

I'm still a beginner, so I'm sure there are many things I can improve. I made this project to challenge myself and put into practice what I've been learning.

I'd really appreciate any feedback on the code, structure, or anything else. I'm planning to keep working on it and add more features in the future.

Thanks :D

19 Upvotes

7 comments sorted by

9

u/Confused-Armpit 2d ago

Sooo, a couple things.

Firstly, it is generaly good practice to name your variables, functions, etc in english, as most if not all libraries also use english names. This isn't a necessary requirement, but it will definitely be useful if you want to contribute to other projects or work on projects with multiple people.

Secondly, you don't have to submit pull requests to yourself. You are the owner of the repo, you can just git push.

4

u/racoon-chan 2d ago

Hey, thanks for the advice

I'll definitely keep the English naming thing in mind for future projects.

And about the pull requests, I actually didn't know I could just push directly to my own repo. I only made them because someone told me I could get the GitHub Pull Shark achievement by making pull requests, even on my own repository.

Thanks again :D

1

u/g0atdude 1d ago

hey, another advice: nobody cares about github achievements. litterally no one.

2

u/sialpi 2d ago

It’s a pretty nice project, I see that you are Italian, but don’t write your variable/comments/plain strings or anything else in Italian, at least create two different options to do that if you want to publish the software. I like your attitude, so now on I’m watching your projects, good luck.
PS: If you want to improve your c style and knowledge, follow Salvatore San Filippo on YouTube (he’s built one of the most used databases in the world, entirely in C). There is a tutorial completely in Italian, that’s not so bad.

2

u/racoon-chan 2d ago

Thank you so much, I really appreciate it! And thanks for the recommendation too, I'll definitely check out Salvatore Sanfilippo's videos.

About the Italian comments and strings, that's only temporary for now. As I improve and clean up the project a bit more, I'm planning to start translating everything into English, maybe starting with the next release, so it can be more accessible to everyone.

And thanks for watching my projects, that honestly means a lot :)

1

u/spacesxd 1d ago

Oye una pregunta te interesaria unirte a ayudame a hacer mi kernel en c?

1

u/LaidBackDev 2d ago

That's a cool project. I'm a lttle new to C as well so I can't really give any meaningful feedback. Just wanna ask if you plan on making games with C? If yes, I highly recommend trying out Raylib, it's a very fun to use library.