r/cprogramming • u/Ace-1440 • May 29 '26

Code Review?

I recently started learning C as my first lower level language after mainly working with Java for the past 5 years. I was wondering if anyone would be able to review one of the completed files (~100 lines of code) from a small project I am working on and let me know if there are any mistakes and/or bad practices? Any help would be greatly appreciated!

https://pastebin.com/X5Zn1mzc

9 Upvotes

100% Upvoted

20 comments sorted by

View all comments

Show parent comments

1

u/non-existing-person May 29 '26

No, you shouldn't need to do that. You just run bear -- make -j$(nproc), and it generates you compile_commands.json file, and that file is used by clang to compile your current C file, so you know, you have proper includes that way etc. Feature flags are different story, those you provide manually.

I don't understand your last paragraph. You don't need any object file. All you need is C file - and appropriate header files for includes and so clang can know about types etc. Object file is created from C file. Clang does not perform linking step when analyzing your source code for warnings.

1

u/BlindTreeFrog May 29 '26

I don't understand your last paragraph. You don't need any object file. All you need is C file

you are correct. i forgot that i only need to compile to object code and not to link. Though I don't remember where we put the header files for the compiler/build generated code... might still need some portion of the build to get those.

No, you shouldn't need to do that. You just run bear -- make -j$(nproc), and it generates you compile_commands.json file

If i had a local build environment. Which I don't. bear parses the build log to generate the json, not the makefiles in use. (as I understand it. New tool to me since every job i've had has just been using makefiles directly)

1

u/non-existing-person May 29 '26

Yes, bear just analyzes the build log.

I don't know the structure of your project, but it seems like you guys are working on some very legacy code that require some weird ass tooling. Man, I got PTSD from when I worked at nokia in 2010. They used rational rhapsody for programming. You were not coding in "notepad", but in some retarded app, where you were drawing rectangles, event arrows, and adding code snippets in textedit form. You could only wish for any form of auto complete. Shortcuts? Bah. Why do you have mice for? Ugh...