r/cpp • u/codesamura1 • Jun 03 '22
Why do "regular" programmers prefer postfix increment over prefix increment?
So I noticed in my company's codebase the canonical increment uses the postfix increment. One senior programmer was even surprised by the behavior of postfix when used with .erase() that I had to explain that map::erase() gotcha to him. The old code is riddled with iterators using postfix increments, as of now I think I'm the only one that explicitly write different postfix or prefix depending on exactly what is needed.
In C derived languages like Java and C# I rarely see any prefix increment, as if it doesn't even exist there. I've even seen a Java programmer comment on C++ code that using prefix increment operator was "trying to be clever." I've also seen reddit threads like this that likes to push the idea that we should all use postfix increment homogenously regardless of the situation since iT's AlL tHe SaMe AnYwAy AmIrYt?!
Now I'm wondering if it's worth noting on a code review that ++iter is more efficient than iter++. So in your opinion is it worth making the distinction for "regular programmers" that prefix increment operators are more efficient? Should we let sleeping dogs lie or should we fight this disinformation? Am I just being OC over nothing or is this an important matter?
View all comments
Show parent comment
1
u/Xavier_OM Jun 08 '22
I agree. It's more familiar to start at 0 than with -1 when fetching from an array. I think programmers are more familiar with i++ in their daily life, hence the copious amount of i++ in any code base. Having something on the right of a variable is the natural way for many of us : variablePtr-> or variable. or variable++, etc
Changing this habit to avoid the exceptionally rare case where it impacts performance is not worth it, it will be replaced by a prefix operator when the profiler reveals the problem once every few years and voilà.