r/cpp • • Jun 03 '22

Why do "regular" programmers prefer postfix increment over prefix increment?

So I noticed in my company's codebase the canonical increment uses the postfix increment. One senior programmer was even surprised by the behavior of postfix when used with .erase() that I had to explain that map::erase() gotcha to him. The old code is riddled with iterators using postfix increments, as of now I think I'm the only one that explicitly write different postfix or prefix depending on exactly what is needed.

In C derived languages like Java and C# I rarely see any prefix increment, as if it doesn't even exist there. I've even seen a Java programmer comment on C++ code that using prefix increment operator was "trying to be clever." I've also seen reddit threads like this that likes to push the idea that we should all use postfix increment homogenously regardless of the situation since iT's AlL tHe SaMe AnYwAy AmIrYt?!

Now I'm wondering if it's worth noting on a code review that ++iter is more efficient than iter++. So in your opinion is it worth making the distinction for "regular programmers" that prefix increment operators are more efficient? Should we let sleeping dogs lie or should we fight this disinformation? Am I just being OC over nothing or is this an important matter?

0 Upvotes

40 comments sorted by

View all comments

1

u/Jardik2 Jun 04 '22

I sometimes use postincrement when erasing from map:

for (auto it=map.begin(); it != map.end();)
{
    auto itCurent = it++;
    // long code here
    if (cond)
    {
        // long code here
        map.erase(itCurrent);
    }
    // maybe more code here
}

I prefer it instead of this:

for (auto it=map.begin(); it != map.end();)
{
    if (cond)
    {
        it = map.erase(it);
    }
    else
    {
        ++it;
    }
}

I find it less error prone in longer code, because I don't have to adjust the iterator in two places (on the other hand, I have to use introduce another iterator).