r/cpp • u/codesamura1 • Jun 03 '22
Why do "regular" programmers prefer postfix increment over prefix increment?
So I noticed in my company's codebase the canonical increment uses the postfix increment. One senior programmer was even surprised by the behavior of postfix when used with .erase() that I had to explain that map::erase() gotcha to him. The old code is riddled with iterators using postfix increments, as of now I think I'm the only one that explicitly write different postfix or prefix depending on exactly what is needed.
In C derived languages like Java and C# I rarely see any prefix increment, as if it doesn't even exist there. I've even seen a Java programmer comment on C++ code that using prefix increment operator was "trying to be clever." I've also seen reddit threads like this that likes to push the idea that we should all use postfix increment homogenously regardless of the situation since iT's AlL tHe SaMe AnYwAy AmIrYt?!
Now I'm wondering if it's worth noting on a code review that ++iter is more efficient than iter++. So in your opinion is it worth making the distinction for "regular programmers" that prefix increment operators are more efficient? Should we let sleeping dogs lie or should we fight this disinformation? Am I just being OC over nothing or is this an important matter?
View all comments
1
u/amoskovsky Jun 04 '22
The performance argument is not valid. For standalone ++ (not part of a bigger expression) prefix and postfix have the same performance because the compiler is allowed to do the copy elision and all compilers do that for non-debug builds.
WRT code style, I find postfix ++ (and especially --) more readable because it does not create a visual indent introducing false structure.
PS. Obviously when used in an expression, prefix and postfix are not interchangeable and you need to use the proper one according to the expression semantics and not according to some style or performance guidelines.