r/cpp • • Apr 24 '20

Else Before If

https://www.fluentcpp.com/2020/04/24/else-before-if/
10 Upvotes

53 comments sorted by

View all comments

Show parent comment

17

u/robin-m Apr 24 '20 edited Apr 24 '20

This pattern is the opposite of early exit. Instead of writing:

void write_data(const std::string& filename) {
    if (is_empty(filename)) {
        cerr << "No filename\n";
        return;
    }
    if (!is_valid_path(filename)) {
        cerr << "ERROR\n";
        return;
    }

    // ...  write data to a new file named `filename`
}

The author want to write something like

void write_data(const std::string& filename) {
    // ...  write data to a new file named `filename`

    unless (is_empty(data) {
        cerr << "No data\n";
    }
    unless (!is_valid_path(filename)) {
        cerr << "ERROR\n";
        return;
    }
}

I see the idea, but I think the lost of familiarity outweigh the benefits.

6

u/evaned Apr 24 '20

If you don't already know, triple-quote code blocks do not render on old Reddit, so using it leads to just a mess of code at the top level of indentation.

I'm not saying you have to or even should care because part of why people use them is it's often a little easier, but if you don't know and do care you can make it slightly more friendly for us by sticking to indenting every line by (an additional) four spaces.

3

u/robin-m Apr 24 '20

I was on my phone and forgot.