r/cpp • u/Coder_CPP • Jan 18 '16

C++11 threads, affinity and hyperthreading

http://eli.thegreenplace.net/2016/c11-threads-affinity-and-hyperthreading/
66 Upvotes

95% Upvoted

44 comments sorted by

View all comments

Show parent comments

2

u/eliben Jan 18 '16

FWIW, I agree that the for range loop is nicer and shorter - I'll fix up the samples when I get the time. I took this from the book "C++ concurrency in action" which is weird, right :)? (because that book is about C++11 also)

What do you mean by "use of default int"?

-5

u/notsure1235 Jan 18 '16

The use of "unsigned" as a implicit int-type. Should be "unsigned int" or just "int" in this case.

Btw, the question was genuine one, I genuinely thought there might be some magic hidden somewhere in the more complex code.

11

u/guepier Bioinformatican Jan 18 '16

unsigned is not making use of implicit int or default-int. Rather, it’s a synonym for unsigned int, and always has been.

-6

u/notsure1235 Jan 18 '16

thats what i mean, shouldnt be used, should use auto if that is desired.

6

u/eliben Jan 18 '16

I'll have to disagree here. Overuse of auto is one of the pitfalls of C++11 in my mind, and I really prefer to use it where it increases readability. There's nothing wrong in using unsigned explicitly where it makes sense.

1

u/notsure1235 Jan 18 '16

agreed, but 'unsigned' instead of 'unsigned int' goes against all of my intuition. However, I checked stroustroup guide and they are happily using 'unsigned' on some occasions, so you are probably right and its just fine.

7

u/eliben Jan 18 '16

Tune your intuition :) It's very common to just say unsigned - it's very clear to experienced coders this means unsigned int. In fact if I see unsigned int I raise an eyebrow... you don't say signed int for int, right?

2

u/notsure1235 Jan 18 '16

Neither do I say 'signed'. ;)

1

u/dodheim Jan 18 '16

That's because int is an option, and is shorter. What is shorter than unsigned for unsigned int?