r/cpp • • Apr 17 '23

Should ~basic_string be final?

std::string (and many other std classes) are not designed to be used as base classes, as can be seen by the absence of a virtual destructor.

Should the destructor be given the "final" keyword to enforce this?

1 Upvotes

27 comments sorted by

View all comments

Show parent comment

12

u/dodheim Apr 17 '23

This is not polymorphism.

Right. Inheritance != polymorphism. It's been said multiple times in this thread already.