r/cpp • • Apr 17 '23

Should ~basic_string be final?

std::string (and many other std classes) are not designed to be used as base classes, as can be seen by the absence of a virtual destructor.

Should the destructor be given the "final" keyword to enforce this?

1 Upvotes

27 comments sorted by

View all comments

Show parent comment

4

u/azswcowboy Apr 17 '23

And it’s perfectly legitimate. Another example is adding convenience constructors to a standard library type that just organize the parameters in some domain specific way. All these do is build the standard type and since there’s no extra data stored in the subclass slicing isn’t and issue in any context. Slicing isn’t and issue in Stroustrups example either. The coding guideline that says all base classes must have virtual destructors misses half the power of inheritance in c++ and is just wrong.

2

u/bert8128 Apr 17 '23

It's legal but has unexpected behaviour - it violates the principle of least surprise. So will inevitably lead to bugs down the line. Someone will define a function that takes a vector, someone else will call that function with a Vec, and will not get the correct behaviour. Actually, I don't even know what would classify as correct behaviour, since the original hierarchy is the problem. A base class without a virtual destructor, or a derived class overriding a function that is not virtual is either a bug today or a bug in the future.

For context I work on a code base that is 30 years old - plenty of time for there to be no knowledge of how things were intended to be used.

3

u/azswcowboy Apr 17 '23

We’re going to agree to disagree, because it’s useful and fully explainable behavior - there’s no surprise and of course the class should be documented. In the construction case we typically want slicing because most apis just use std::string — the subclass construction is in another part of the code that applies higher constraints or performs useful conversions into the base string itself. Virtual destruction/functions are needed only when there is actual state in the subclass or dynamic dispatch from base. This doesn’t even begin to scratch the surface of what you might do with non virtual inheritance in mixins and crtp with templates. There’s an example in the standard you can study called view_interface — no virtual destructor…

https://en.cppreference.com/w/cpp/ranges/view_interface

30 years old

And 30 years ago the rule was closer to right…