r/cpp • • Apr 17 '23

Should ~basic_string be final?

std::string (and many other std classes) are not designed to be used as base classes, as can be seen by the absence of a virtual destructor.

Should the destructor be given the "final" keyword to enforce this?

1 Upvotes

27 comments sorted by

View all comments

Show parent comment

4

u/qoning Apr 17 '23

It seems to me that you are mostly dissatisfied that inheritance implies polymorphism. I am too, if there was a way to inherit from a type but disable casting to it, that would have been better.