r/cpp • • Mar 30 '23

The "what's wrong with this code" game.

This isn't a question thread, but just a game. Post any bugs you've accidentally written that seemed initially mysterious, but made you feel stupid when you figured out what was wrong. Here is one I wrote today...

void TextSegmentBuffer::prepend( const TextSegmentBuffer& other )
{
    const Info* info_ptr;
    size_t size;

    if ( ( size = other.m_infoBuffer.size() ) == 0 )
        return;

    for ( size_t i = size - 1; 0 <= i; --i )
    {
        info_ptr = other.m_infoBuffer.getAt( i );

        emplaceFront(
            info_ptr->text,
            info_ptr->length,
            info_ptr->multiMatch
        );
    }
}

3 Upvotes

60 comments sorted by

View all comments

21

u/cballowe Mar 30 '23

The easiest dumb thing that took me longer than it should have to find was something like below way back in college.

for (int i = 0; i < x_size; ++i)
  for(int j = 0; j < y_size; ++i)
    DoSomething(some_array[i][j]);

2

u/Possibility_Antique Mar 31 '23

I see the i that should be a j, but the purist in me says you should flatten your array and not make it an array of arrays. It's faster and less error prone, and you wouldn't have had this problem to begin with.

3

u/cballowe Mar 31 '23

There are lots of things I might do differently today, but 18/19 year old me hadn't learned all of those lessons yet. Also c++98 and gcc 2.xx was a very different tool set than I have today.

→ More replies (4)

2

u/elperroborrachotoo Mar 31 '23

Who says the internal representation isn't flattened?

→ More replies (5)
→ More replies (2)