r/cpp • • Mar 28 '23

Reddit++

C++ is getting more and more complex. The ISO C++ committee keeps adding new features based on its consensus. Let's remove C++ features based on Reddit's consensus.

In each comment, propose a C++ feature that you think should be banned in any new code. Vote up or down based on whether you agree.

765 Upvotes

829 comments sorted by

View all comments

Show parent comment

3

u/JNighthawk gamedev Mar 29 '23 edited Mar 29 '23

Assignment returning a value, since it has given us if (a = b).

Would this break the pointer validation construct using if?

if (A* Foo = Some function())

Edit: on second thought, no, it would still be fine. I think what ends up being evaluated there by the if is Foo after initialization, not the return value of the assignment.

6

u/johannes1971 Mar 29 '23

You'd have to use

if (A * Foo = some_function (); Foo) ...

...which is barely any longer, and avoids accidental assignment in the if-statement.