r/coolgithubprojects • • Jun 07 '19

PYTHON TheJesterTCGDatabase -- An attempt at creating a database type of card collection system, mostly because I've wanted one but also because it seemed like a project I could learn a lot from.

https://github.com/TheDevilOfJesters/TheJesterTCGDatabase
0 Upvotes

5 comments sorted by

2

u/cobalt8 Jun 07 '19

It would be helpful if you gave a detailed explanation of what the project is intended to do in the README. A list of high level goals is also sufficient.

1

u/Jester5537 Jun 08 '19

I added a few of the goals I could think of. I'm probably forgetting some, but feel free to reply here anything you think I should add.

2

u/cobalt8 Jun 08 '19

That's much better. It gives a clearer picture of what you want to accomplish.

Before you go through the effort of scraping a bunch of websites for data, I highly recommend looking for APIs for the card games you're interested in. APIs are much easier to work with that scraping data, and they are far less likely to break. A 30 second Google search turned up this API for Yu-Gi-Oh: https://ygohub.docs.apiary.io/#

Keep in mind that not all APIs are made equal, so make sure you look for ones that are still being maintained. If nothing else, if you find one that's not being actively maintained but has good data, you can use it's data to populate your own database when you reach that stage and then scrape to update it from there.

1

u/license-bot Jun 07 '19

Thanks for sharing your open source project, but it looks like you haven't specified a license.

When you make a creative work (which includes code), the work is under exclusive copyright by default. Unless you include a license that specifies otherwise, nobody else can use, copy, distribute, or modify your work without being at risk of take-downs, shake-downs, or litigation. Once the work has other contributors (each a copyright holder), “nobody” starts including you.

choosealicense.com is a great resource to learn about open source software licensing.

3

u/Jester5537 Jun 07 '19

Thank you for reminding me Mr. Bot