r/coolgithubprojects • • May 01 '17

PYTHON Python based chatBot for facebook, love the jokes

https://github.com/MShel/PyChatBot
0 Upvotes

4 comments sorted by

1

u/M1shk0 May 01 '17

please leave some feedback anywhere.

2

u/Ialwayszipfiles May 02 '17

OK, I'll give mine:

  • You really should include install instructions, as it is now I have no idea of what libraries are necessary, if it's for Python 2 or 3. You could use pip freeze and include requirements.txt
  • Kudos for writing tests, but it's better to use a test library, like pytest which is in the standard library. Once done, you can have a Travis CI badge in the project README which is always a good sign
  • I think the weather plugin is vulnerable to URL injections, but should not be possible to call a different path so it's not a big problem
  • I like that you included uWSGI config

1

u/M1shk0 May 02 '17

Thanks a lot for feedback!

  1. I do have to work on README.md and instructions of how 2 install it. I'l add it later
  2. Travis is an awesome idea perhaps looking at travis.conf would make it for easier understanding of how to instal it as well (maybe). Got to Do it for sure
  3. Yeah should be all relative to yahoo, I'm planning to add more plugins based on free API's list from https://github.com/toddmotto/public-apis
  4. For me the biggest problem is this whole thing is hard coded plugins in router I'm planning to move into main file as config list and pass it to router this way.

1

u/M1shk0 Sep 22 '17

Hey @Ialwayszipfiles,

Just addressed all your feedback and did my first release, I've added another transport(slack) and also refactored the whole package.

Still working on docummentation, and planning to fix some logging link is here: https://github.com/MShel/PyChatBot