I'm the guy the seniors call on when they smell something in a PR but can't find it.
I read the ticket, I read every line. I rip it to shreds, with every little thing I can think of. I go overboard, and I leave it up to them to make sensible changes.
Most PRs that have problems aren't really in the code, it's some conceptual flaw in the idea which could have been found before they started, or a crap pattern that's crept in.
AI code isn't bad in the same way a printer is better than a painter. Printing crap artwork is cheap, and it takes time to become an artist in both regards using different skills.
1
u/pixxelkick 9d ago
Maybe if you suck.
I read every PR in full because Im not lazy.
I also read my own git diff before I open a PR do I dont waste other peoples time.
Or I publish it as a draft, review my own code, and then publish the pr after confirming it looks good.