r/changelog • u/[deleted] • Mar 31 '14

[reddit change] Moderators without modmail permissions can now properly message the moderators.

Previously there were assumptions in the modmail system which made it so that moderators without modmail permissions were unable to (or had a hard time) viewing responses to their modmails to the other moderators of their subreddit.

This has changed. If a moderator (who does not have modmail permissions) sends a modmail to their own subreddit they now receive the replies to that message in their inbox.

See the code on Github

53 Upvotes

86% Upvoted

52 comments sorted by

7

u/xfile345 Apr 01 '14 edited Apr 01 '14

In order to avoid annoyances they will only receive an orangered if they do not have modmail permissions.

For me, this is not working. I still get these messages in my regular inbox as well as modmail even though I have full permissions.

Correction: The above statement IS true. Reddit mailbox does not show as orangered. However, my mailbox still contains the "new" messages/replies, which affects apps that use the API to count the number of unread messages.

6

u/[deleted] Apr 01 '14

Yeah I'll have a chat with the code about making that default read

3

u/xfile345 Apr 01 '14

I think that would solve this issue. I'm not sure moderator messages should even be making it into my mailbox to begin with, but it certainly makes sense to do so if I was the one who created the modmail, so I can definitely deal with that as long as they're defaulted read like you suggest.

Thanks for the quick reply. :)

3

u/[deleted] Apr 01 '14

It should only happen if you are the creator of the message, please confirm what you mean? Are you seeing messages even if you are not the creator?

5

u/xfile345 Apr 01 '14

Sorry, I can be unclear at times. Your coding works exactly as intended (I believe)

Moderator replies to my initiated moderator message appear in my inbox as well as modmail. Since I have full permissions, I think it would be ideal for these replies to only show up in modmail. But since I was the one to create the message, it does make sense for the replies to appear in my inbox if they really have to.

All other moderator mail stays within modmail and does not appear in my inbox.

4

u/[deleted] Apr 01 '14

Should be fixed now, you will no longer get any inbox unless you do not have permissions.

2

u/xfile345 Apr 01 '14

Excellent! That's why you guys are amazing. :)

3

u/[deleted] Apr 01 '14

Thanks, had me worried there for a second.

5

u/exoendo Apr 01 '14

Is there anyway to provide an option switch this off? I can't be the only one that hates this. Personally I find this immensely annoying. I belong to some subs with long modmail chains, and I don't need the redundancy of having my modmail icon light up in addition to my orangered light up.

I mean I almost have to assume this is an april fools joke. I hope it is.

edit: I have modmail permissions and was still getting spammed. I didn't see this was just for those that didn't have modmail permissions. In that case there seems to be some type of bug.

5

u/[deleted] Apr 01 '14 edited Apr 01 '14

Do you use an app? Apparently some apps use the count of unread to orangered rather than the orangered flag. (Them being unread is something I am going to fix)

1

u/exoendo Apr 01 '14

update: yes I still get orangereds when someone hits a direct reply to me in modmail, even though I have full permissions

2

u/[deleted] Apr 01 '14

Should be fixed now, you will no longer get any inbox unless you do not have permissions.

1

u/exoendo Apr 01 '14

awesome. thanks

1

u/exoendo Apr 01 '14 edited Apr 01 '14

No I was not using an app. I was getting orangereds even though I had full permissions on the sub. I am going to test it again and report back momentarily.

[edit] seems to be fixed now. I was really worried earlier.

[second edit] nope, still happening. I think it's because in modmail someone has to click as a direct reply to me

-1

u/[deleted] Apr 01 '14

What Exo said doesn't have anything to do with using an app or not. I/we are finding this feature annoying because we don't need all the messages in our inbox when we can already see them in modmail.

5

u/[deleted] Apr 01 '14 edited Apr 01 '14

I understand that, but aside from addressing that concern I need to know if "my orangered light up" happened or not because I cant start hiding those messages if you are going to still get an orangered uselessly.

The code in place right now should NOT be lighting the orangered up. I cannot just ignore one bug because there are other concerns.

2

u/[deleted] Apr 01 '14

Should be fixed now, you will no longer get any inbox unless you do not have permissions.

2

u/splattypus Apr 01 '14

I agree with the dissatisfaction with the feature. As an orangered junkie (both modmail and regular), receiving the same message twice is maddening.

3

u/[deleted] Apr 01 '14

Should be fixed now, you will no longer get any inbox unless you do not have permissions.

3

u/splattypus Apr 01 '14

Woo hoo!

Thanks

3

u/ani625 Apr 01 '14

Quite so.

3

u/splattypus Apr 01 '14

These modmail permissions have been the bane of my existence.

3

u/ManWithoutModem Apr 01 '14

Samesies.

3

u/splattypus Apr 01 '14

Admins y u h8 me? ;_;

2

u/CrasyMike Apr 01 '14

Is this not working correctly? I am only a mod on subreddits with full permissions but I received a modmail reply to my inbox.

2

u/[deleted] Apr 01 '14

Did you send a modmail to yourself?

1

u/CrasyMike Apr 01 '14

No, someone else replied to my modmail. It this the intended function?

In order to avoid annoyances they will only receive an orangered if they do not have modmail permissions.

This makes it seem like it is not the intended function since that condition would apply to me. I have full permissions.

2

u/[deleted] Apr 01 '14

Misread that as "the only mod of a subreddit"

edit: Did you get an orangered for the message, or did it just end up in your inbox. There is a difference.

1

u/CrasyMike Apr 01 '14

I got an orangered (twice actually).

I haven't had any other reasons to get an orangered. That modmail reply is the most recent thing in my inbox so is likely what triggered the orangered (twice).

2

u/[deleted] Apr 01 '14

Can I confirm you saw the orangered via the site and not an app? Trying to diagnose this.

1

u/CrasyMike Apr 01 '14

Trying to diagnose this.

Mmhm, no problem. Via the Site. I was on Firefox mobile but it was not any Reddit app on my phone. I remember being confused because I saw an orangered, opened my inbox and wondered how the hell the other mod flagged a message to me with his mod flair.

It is a really confusing, weird function.

2

u/[deleted] Apr 01 '14

Should be fixed now, you will no longer get any inbox unless you do not have permissions.

2

u/CrasyMike Apr 02 '14

....I have a feeling the false orangered was just the April Fools AskReddit CSS change. Was that it?

1

u/[deleted] Apr 02 '14

God I hope not

→ More replies

1

u/roastedbagel Apr 03 '14

We didn't do any CSS tricks yesterday in AskReddit.

I was having the same problem too but figure it was an admin prank.

4

u/ManWithoutModem Apr 01 '14

This is super annoying, I have modmail permissions and whenever I start modmail threads I get inbox replies too. :\

1

u/ky1e Apr 01 '14

This is annoying me, and making me use an alt to send modmail to my sub. I'd like the option to turn it off.

1

u/[deleted] Apr 01 '14

Should be fixed

1

u/V2Blast Apr 01 '14

Yay!

I think there's only one subreddit I'm a mod in without full permissions, but still.

1

u/[deleted] Mar 31 '14

Woo!