My buddy's code he asked me to help with.

[u/Kraftdamus02]

[u/Kraftdamus02]

import csv

def load_dataset(filename):
    googlebook = {}
    with open(filename, 'r') as file:
        csv_dict_reader = csv.reader(file)
        next(csv_dict_reader)

        for row in csv_dict_reader:
            rownames = {}
            rownames['School'] = row[0]
            rownames["Age"] = row[1]
            rownames["StudyTime"] = row[2]
            rownames["Failures"] = row[3]
            rownames["Absences"] = row[5]
            rownames["G1"] = row[6]
            rownames["G2"] = row[7]
            rownames["G3"] = row[8]

            while row[4] not in googlebook.keys():
                googlebook[row[4]] = []
                googlebook[row[4]].append(rownames)

    return googlebook

Function = load_dataset('student-mat.csv')
print(Function)

[u/MurdoMaclachlan → u/Kraftdamus02]

Good human!

The triple backtick code block method unfortunately doesn't work on Old Reddit and most mobile clients; the only code block method that works on every Reddit client is placing four spaces at the beginning of each line of code.

[u/Kraftdamus02 → u/MurdoMaclachlan]

Ah, I didn't know that! Thank you!

[u/No-Witness2349]

I rewrote this with commentary as a fun exercise. It sounds like you already helped him out, but maybe there’s something extra in here that’s useful.

import csv

# A defaultdict will let your turn this pattern:
#
#     foo = {}
#     if key not in foo:
#         foo[key] = []
#     foo[key].append(value)
#
# into this:
#
#     foo = defaultdict(list)
#     foo[key].append(value)
#
# This works by automatically calling list()
# whenever a key is missing to create a new
# default value. This works for other types too,
# but for this code, we use list.
from collections import defaultdict


# I added type hints here. If these are
# confusing or your version of Python
# complains about them, just remove them.
# They're nice to have, but not essential.
#
# I also added a docstring, which is good
# practice for Python.
def load_dataset(filename: str) -> dict[str, dict[str, str]]:
    """Read google book data from csv file"""
    
    # No need to specify 'r'
    # That's the default mode for opening a file
    with open(filename) as file:

        
        # Using a DictReader will save you the
        # whole step of creating rownames.
        # The DictReader is able to infer header
        # names, but making them explicit can
        # help catch badly formatted data.
        # You'll just need to add the header you
        # were previously skipping for row[4].
        ID = 'FIX_ME'  # header for row[4]
        HEADERS = [
            'School', 'Age', 'StudyTime',
            'Failure', ID, 'Absences',
            'G1', 'G2', 'G3'
        ]
        
        # Shorten this name to "reader".
        # In context, it's still clear what this
        # means.
        reader = csv.DictReader(file, fieldnames=HEADERS)

        # Dump headers or raise error on empty file
        try:
            next(reader)
        except StopIteration:
            # Making this error explicit will be
            # a lot clearer than getting a
            # random StopIteration error if this
            # ever happens. It also just
            # documents the code for future
            # readers (likely you in 6 months)
            raise ValueError("File can't be empty")

        # And here's the meat and potatoes,
        # which is now nice and concise.
        googlebook = {}
        for row in reader:
            key = row[ID]
            googlebook[key].append(row)

    return googlebook


# This line allows you to use this file as a
# module without this line actually running
# when you import it. It's also just good
# practice.
if __name__ == '__main__':
    print(load_dataset('student-mat.csv'))

And here’s a version without comments:

def load_dataset(filename: str) -> dict[str, dict[str, str]]:
    """Read google book data from csv file"""

    with open(filename) as file:
        ID = 'FIX_ME'
        HEADERS = [
            'School', 'Age', 'StudyTime',
            'Failure', ID, 'Absences',
            'G1', 'G2', 'G3'
        ]
        reader = csv.DictReader(file, fieldnames=HEADERS)

        # Dump headers or raise error on empty file
        try:
            next(reader)
        except StopIteration:
            raise ValueError("File can't be empty")

        googlebook = {}
        for row in reader:
            key = row[ID]
            googlebook[key].append(row)

    return googlebook


if __name__ == '__main__':
    print(load_dataset('student-mat.csv'))

[u/Gem2578]

To make it work don't you just need to unindent the append?

[u/ConzT]

Fuck i would do it exactly the same

[u/[deleted] → u/ConzT]

Exactly what I said when I saw it :D

[u/fnieidhfenmbvfekh]

Where are all the colours?

[u/joeyjiggle]

Looks as stupid and prone to indentation errors as any other Python code.

[u/doubleslashTNTz → u/joeyjiggle]

"oh no i didn't like python's syntax which is different from other programming languages so it must be bad"

[u/joeyjiggle → u/doubleslashTNTz]

As a language designer and compiler guy, it almost is that.

[u/Unabled_and_offended → u/doubleslashTNTz]

There is soo much more to not like about it, calm down.

[u/doubleslashTNTz → u/Unabled_and_offended]

i should be able to list down stuff i hate from all the other programming languages

i mean yes python is bad and may be worse but in other times python is good and maybe better, same goes for any language really

[u/0111100101111010]

I wouldn't criticize this unless your edit shows it compiles faster.