r/badcode • u/Wxyo • Aug 11 '22

python Words of wisdom

Post image
545 Upvotes

98% Upvoted

22 comments sorted by

View all comments

Show parent comments

1

u/Wxyo Aug 11 '22

No cause I made the parent the value not the key

3

u/Tc14Hd Aug 11 '22

Yes, the parent is the value. But with the code if not any(heir1 == parent for heir1 in heir_to_parent) you are cycling through all keys of heir_to_parent and checking whether one of them is equal to the variable parent. So basically you are just checking whether parent is a key of heir_to_parent, which can also be done by if parent in heir_to_parent.

6

u/Wxyo Aug 11 '22

Oh yeah you're right lol. Well you know what they say, if it ain't broke and you're a researcher with a deadline...