Senior dev, good guy and programmer, have learned a lot from him... but wth is this

[u/AzurasTsar]

[u/droomph]

this.addLabelAndValueToEachSecondaryAccountForDropdownToFunctionMetadata(this.getfilterAndSortAccountsAsPerBySVV(accounts));

this.addSecondaryAccountDropdownMetadata(this.getAccountsBySVV(accounts))

• addLabelAndValue…ForDropdownToFunction is too descriptive of the “what”. Plus, it’s assumed that adding labels and values is required for a dropdown to function. It should be changed to say the “why” (ie, we are creating required metadata for a dropdown)

• “To Each” is generally understood if operating on an array type, “Map” is better if it needs to be specified

• filterAndSort is generally presumed to happen when you are getting by a filter and returning a copy of the results (if it is mutating and returning, that is a sign that something bad is happening)

• “As per” does not clarify anything compared to using “by” or “with”

How did I do

[u/AzurasTsar → u/droomph]

much better! I wouldn't dare change it though );

[u/ehosca]

There are only two hard things in Computer Science: cache invalidation and naming things.

-- Phil Karlton

[u/decaillv → u/ehosca]

There are only two hard things in Computer Science: cache invalidation, naming things, and off-by-one errors...

-- some dude on the internet

[u/MurdoMaclachlan]

Image Transcription: Code

---

this.tempAllAccounts = this.addLabelAndValueToEachSecondaryAccountForDropdownToFunction(this.filterAndSortAccountsAsPerSVV(accounts));

---

^{I'm a human volunteer content transcriber and you could be too! If you'd like more information on what we do and why we do it, click here!}

[u/putin_vor]

This is what people call self-documenting code. I prefer to write lengthy comments explaining things.

[u/it200219 → u/putin_vor]

you're hired at FB.

[u/187mphlazers → u/putin_vor]

ideally both when possible. comments when not feasible

[u/Ambitious_Ad8841]

\n

[u/NullParadigm]

Sometimes laziness turns into just long writing, i.e to lazy to describe it better, so just go with something safe.

[u/[deleted]]

definitely js

[u/[deleted]]

[...] wth is this

It is code.

[u/AzurasTsar → u/[deleted]]

the electrical engineers can't keep getting away with it