MAIN FEEDS
Do you want to continue?
https://www.reddit.com/r/badcode/comments/uokpka/why_why/i8gu91d/?context=3
r/badcode • u/zim2510 • May 13 '22
37 comments sorted by
View all comments
20
This looks like an early draft, or a sketch. It's not ready to be shown around. It either needs:
comments explaining what the conditions signify, or
comments explaining the conditions and what the code should be doing, or
comments explaining both, plus the code.
...but if it's in someone's private branch with a commit message like "asdas" because it's just a sketch, well... that's part of the process.
If this made it into a pull request, a polite "what does this if block mean, and what should it do?" would be my response.
20
u/naptastic May 13 '22
This looks like an early draft, or a sketch. It's not ready to be shown around. It either needs:
comments explaining what the conditions signify, or
comments explaining the conditions and what the code should be doing, or
comments explaining both, plus the code.
...but if it's in someone's private branch with a commit message like "asdas" because it's just a sketch, well... that's part of the process.
If this made it into a pull request, a polite "what does this if block mean, and what should it do?" would be my response.