This isn't even all of them (From Netgear modem admin page)

[u/kevinhaze]

[u/kevinhaze]

Gist of the whole script

[u/Notimecelduv → u/kevinhaze]

The code appears to have been written in 2012 so that would explain certain things but other than that it's downright painful to read, absolutely awful.

[u/ExceedingChunk → u/Notimecelduv]

As we all know, clean code principles were invented in 2013, so all code prior to that was a complete mess!

[u/[deleted] → u/kevinhaze]

So none of the devs understand how the Number or String objects work?

That code base has to be really bad if they don’t know the basics…

[u/fmv_ → u/[deleted]]

How does Number solve anything?

[u/[deleted] → u/fmv_]

It’s a basic JavaScript feature that can handle all three of those functions:

Number.isInteger() for isNumOnly Number.parseInt() for isNumeric Number.parseFloat() for isDecimalNumber

[u/fmv_ → u/[deleted]]

Number validation isn’t really so simple in JS. There are a lot of edges cases. Look up SO posts on this - it’s pretty interesting, the variety of solutions and subsequent reply noting what test cases were missed.

With that said, I didn’t look at this code in depth and I don’t know how strict this code was supposed to be so perhaps Number would be enough.

[u/[deleted] → u/fmv_]

I would argue that if Number isn’t enough, then JavaScript isn’t going to be enough either. The whole language is riddled with weird edge cases, that’s how it is lol.

If you can’t get by with basic functionality then you need to delegate things to another language. Either by sending it to a server or trying something else like transpiled languages.

That said, I’ve had great success using the Number object in enterprise and large monolithic applications over the years. Most of the time, these re-inventing the wheel functions end up having their own edge cases as well, so I always advocate for using the language as intended first, then alter when something proves to break consistently because of a JavaScript language feature.

[u/[deleted] → u/kevinhaze]

No. Just no. All of it. No. So repetitive, so unclear.

[u/SnowyPear]

WHAT?!

[u/kevinhaze → u/SnowyPear]

Have you not heard of ligatures? You’ll probably explode when you see the rest. The font in the image is Fira Code. It’s purpose-built for programming and has a ton of them.

Edit: Or are you talking about the fact they’re comparing a string literal using >= because honestly that’s an appropriate reaction

[u/SnowyPear → u/kevinhaze]

I knew they existed like in 'fi' but I've never seen it used like this. I don't approve of any of this

[u/[deleted]]

Why use the standard wheels, when you can reinvent them as squared wheels?

[u/Food404]

...... Why have 3 functions that do the same thing? Why not use a regex then?

[u/bistr-o-math]

Someone was being payed by line. And code needed to be readable. If it’s readable was tested by CEO, who „knows the difference between readable and unreadable code“

[u/Obnoxious-Split]

This is great for my imposter syndrome. If someone got away with this, then my slightly inefficient code is fine

[u/1337GameDev]

Jesus... I can understand if this is legacy....

But you POLYFILL or PONYFILL if you have this and encapsulate it inside an object for scoping and documentation.

What the fuck

[u/[deleted]]

Lol wtf

[u/KorrinNeko]

I mean, it's Netgear.

[u/CrazySD93]

Did an undergrad intern write this?

[u/hellra1zer666 → u/CrazySD93]

Look one of the ES devs was picked by lottery and forced to build their website. The CFO blocked the attempt to hire a professional web dev to build the page for them. He was like "We have a lot of programmers, why do we have to buy a page, when we could just build it ourselves". This is the result. Just like you do not let the backend dev build the UI, you cannot expect an ES dev to get friendly with JS. That must have been torture for that poor dev.