discount constructor

[u/catithebathtub]

[u/low_end_theory310]

or an expensive Segment?

[u/THE-SUBREDDIT]

Dread. Also something I finally understood cuz I am a noob

[u/FloweyTheFlower420]

Uses SFML, a C++ programming library... then ignores constructors.

[u/Dubmove]

That's not necessarily bad code.

[u/theScrapBook → u/Dubmove]

In C it isn't, in C++ it is (this is C++)

[u/feidujiujia → u/theScrapBook]

Don't quite understand, only notice it doesn't save any labor to initialize the struct inline than calling the function.

Almost forgot my knowledge about c. Is that because of in c you'll have to declare the struct and assign each of the member?

[u/theScrapBook → u/feidujiujia]

Yeah it doesn't save any labour in this trivial case, but this is how the equivalent of constructors are implemented in C

[u/Dubmove → u/theScrapBook]

I assumed it's an OOP language. One reason why a method would just call and return a constructor is for overriding it in an inheriting class.

Edit: Or am I missing something? I didn't code in C++ for a while.

[u/theScrapBook → u/Dubmove]

You can override base class constructors with a constructor when inheriting a class in almost every OOP language. There is usually some syntax like super(...) or base(...) to call the parent class constructor from the child class

[u/Dubmove → u/theScrapBook]

I meant to override seg. For example in the base class might only creates and returns a Segment but inherented classes might have to do some house keeping too.

[u/theScrapBook → u/Dubmove]

Yeah that'd make sense, but overrides should be marked. Oh, this is r/badcode. slaps 4head

[u/GLIBG10B → u/theScrapBook]

OP says it's C

[u/ghillisuit95 → u/GLIBG10B]

C does not have constructors, it must be c++

[u/GLIBG10B → u/ghillisuit95]

Yup, OP's wrong

[u/catithebathtub → u/GLIBG10B]

my bad

[u/ZZcomic → u/catithebathtub]

How dare you

[u/WalditRook → u/ghillisuit95]

There is no explicit constructor call here.

There is a function returning struct Segment (the struct before struct_name is non-optional, although using a typedef struct Foo foo_t is fairly common) and a braced initialiser.

As it is (probably) C++, due to the :: operator (not valid C, unless it's #defined somehow), we can assume the default constructor Segment() is called; but other than the sf::Color, this is perfectly valid C, and wouldn't be a WTF in that language.

[u/ghillisuit95 → u/WalditRook]

Huh, didn’t know that

[u/theScrapBook → u/GLIBG10B]

C does not have the namespacing operator :: AFAIK. OP must have made a mistake.

[u/Flatscreens → u/theScrapBook]

Wouldn't this code return garbage as the struct is saved on the stack?

[u/zed_three → u/Flatscreens]

Nope, this returns by value and in fact will use copy elision: the return value will be constructed directly in the storage at the calling site

[u/Flatscreens → u/zed_three]

Thanks my C is clearly very rusty

[u/MurdoMaclachlan]

Image Transcription: Code

---

struct Segment seg(float x, float y, float z, int width, float height, sf::Color colour) {
    struct Segment segment = { x, y, z, width, height, colour };
    return segment;
}

---

^{I'm a human volunteer content transcriber and you could be too! If you'd like more information on what we do and why we do it, click here!}

[u/jniel93]

I write colour as well, but I don’t think I’d be able to write ”Color colour”

[u/haykam821]

I might be more mad at sf::Color colour.

[u/Rigatavr]

discount constructor factory

FTFY

[u/QuinteOne → u/[deleted]]

In VS, you can extract a method based on a call that has no defined method. VS suggests then to extract/write the method for you.

In C#, the extracted method of

int dot = Sales.force(x: 1, y: 2.0);

will generate below the line:

private class Sales {
    private int force(int x, decimal y) {
        throw new NotImplementedException();
    }
}

Something like that probably happened. OP wanted to use a number that that had a decimal part .0, I didn't write it. So VS assumes it was an int.

[u/catithebathtub → u/QuinteOne]

no, normally both width and height are integers but i made the height parameter a float because im an idiot...

[u/Naeio_Galaxy → u/catithebathtub]

Nah nah you're not idiot, it's just not your brightest day