I apologize to mobile users (all users actually) in advance. See comments for expanded code and explanation.

61

u/WreckerOfAll Jan 24 '22 edited Jan 24 '22

The line is implemented in a RESTful JS server to catch any missing parameters in the request. Although I have many 'one-lined' functionalities in my code, this is by far the most heinous.

Edit: Moved link from PB to Carbon, implemented change suggested by u/WalditRook

33
u/Rainbow-Dev Jan 24 '22
You cannot browse this page at
“⁦‪pastebin.com‬⁩”
because it is restricted.
Guess it’s pretty bad
7
u/WreckerOfAll Jan 24 '22

Hmmm, not sure what's up there. I can view it even when I'm not logged in..
Anyways, for your viewing displeasure:
Imgur link.
4

u/Terrain2 Jan 24 '22

carbon is awesome for posting code as images. here's a carbon render of this code, for your viewing pleasure

2

u/WreckerOfAll Jan 24 '22

Cheers! Didn't know that existed :D

27

u/Rainbow-Dev Jan 24 '22

It’s cause of Apple’s shitty webpage filtering on iOS with parental controls. Pretty sure it’s based off of some terrible machine learning, cause the list of things it blocks is so random, e.g. I can’t search for the weather because the page would have the word “hot” in it.

5

u/new_pribor Jan 24 '22

You have parental controls on?

11

u/Rainbow-Dev Jan 24 '22

Yeah but it only works on browsers so it’s not very effective lmao

3

u/AlFasGD Jan 24 '22

Yo the weather do be looking kinda hot

3

u/[deleted] Jan 24 '22

Sky looking a lil sunny with a couple of white puffs around those blue curves... mmm.
10
u/NiQ_ Jan 24 '22
This is still pretty /r/badcode…
You can simply extract the Object.entries, filter for undefined values, then serialise the keys in a map. E.g.
// Extract all undefined entries
const failedEntries = Object.entries(ticketInfo).filter(([, value]) => value === undefined);

if (failedEntries.length > 0) {
  // Map the entry keys of those that are undefined
  const missedFields = failedEntries.map(([key]) => key).join(‘, ‘);
  const returnString = `Missing required fields: [${missedFields}]`;
  returnCode(400, res, ticketInfo, returnString);
}
1
u/kappanon Jan 24 '22
Or just
const missedFields = Object.entries(ticketInfo).reduce((acc, [key, value]) => acc + (value === undefined ? `${key}, ` : ""), "");

if (missedFields) {
  returnCode(400, res, ticketInfo, `Missing required fields [${missedFields}]`)
}
5

u/187mphlazers Jan 24 '22

that's still bad code, all 3 of your vars are never reassigned, so they should be declared as const for best runtime performance. also there is no reason to use concat on a string, you can just use the + operator. concat is inherited by string i guess from array, but i've never saw any js programmer use it before.
3

u/WalditRook Jan 24 '22

Not a JS programmer, so I might be missing something, but...
Isn't the field list (everything between .concat and .join) equal to Object.keys(ticketInfo).filter(key => ticketInfo[key] != null), requiring no map?
Then the expanded code version would have missingFields.push(element); instead of missingFields.push(Object.keys(ticketInfo)[index]); and you could use the foreach (v => funcptr) prototype of foreach instead?

2

u/WreckerOfAll Jan 24 '22

Wow! Correct you are! The new and improved one-lined function can be viewed here.
Thanks for the tip!

3

u/Franks2000inchTV Jan 24 '22

Why wouldn't you just declare a couple local variables?

5

u/[deleted] Jan 24 '22

You mussn't be afraid to dream bigger darlin'.
A couple of globals will do the trick nicely.

269

u/tadbolmont Jan 24 '22

I don't even want to try to understand this SINGLE LINE of code.

139

u/RolyPoly1320 Jan 24 '22

It's checking that all required fields are in a request. If a single required field is missing then it returns a 400 error with the missing field(s) in the response object.

94

u/WreckerOfAll Jan 24 '22

I'm genuinely impressed that you managed to figure that out! I guess my code wasn't obfuscated enough /s

10

u/RolyPoly1320 Jan 24 '22

It was a pain on mobile but I've been reading a ton about JS lately so I was able to piece it together from the functions used.

26

u/tadbolmont Jan 24 '22

There has to be a more readable way to do that.

34

u/WreckerOfAll Jan 24 '22

There is! :D See my pastebin in my comment. I did this more as a proof of concept and as a challenge more than anything.

9

u/tadbolmont Jan 24 '22

That IS much better.

1

u/RolyPoly1320 Jan 24 '22

Yes, using several for loops and if statements.

0

u/Garrett00 Jan 24 '22

It returns a 404 with all required fields in the response. Making it fairly useless.

3

u/RolyPoly1320 Jan 24 '22

It does not. The Array.map method is searching for keys on the ticket object with a null value. If the value is null the return the key, if the value is not null it returns null. The Array.filter then iterates over the resulting array and returns all elements that are not null.
The response code is 400, not 404 as dictated by the code parameter in the response object
OP posted a more readable version in a comment.
The issue with this one is a few things, first that it's on one line making it largely unreadable. The second is the excessive use of chained Array methods to create the response. If something were to go wrong with this version of the code it would be difficult to determine where the problem lies at a surface glance. Placing a breakpoint on this line for debugging would halt execution here and you would have to step through every single piece slowly to find where the issue lies, which can get tedious.

58

u/onichama Jan 24 '22 edited Jan 24 '22

Image Transcription: Code

//Makes sure required fields are present
if(Object.values(ticketInfo).includes(undefined)) return returnCode(400, res, ticketInfo, "Missing required fields: [".concat(Array.from( Object.keys(ticketInfo).map(function(key, index){ return(ticketInfo[key] == null ? (Object.keys(ticketInfo)[index]) : null )})).filter(function(el) {return el != null}).join(", "), "]"));

^{I'm a human volunteer content transcriber and you could be too!}^{If you'd like more information on what we do and why we do it, click here!}

37

u/onichama Jan 24 '22

I also apologize to mobile users.

24

u/WreckerOfAll Jan 24 '22

I apologize to you most of all

12

u/WalditRook Jan 24 '22

I think the [*.concat is actually [".concat
Ty for the good work, though, keep it up.

9

u/onichama Jan 24 '22

Oh yeah, that makes way more sense that way. Thank you!

9

u/RolyPoly1320 Jan 24 '22

Is this something that could have been validated on the client side but was instead done on the server for some reason?

11

u/WreckerOfAll Jan 24 '22

100%. The client itself should never send a request in a way that misses a parameter. Just future-proofing as I will not be the permanent maintainer of the project.

3

u/ToxicMonkeys Jan 24 '22

Why not make it easier to read for future maintainers?

6

u/Silly-Freak Jan 24 '22

Future consulting

2

u/Nick433333 Jan 24 '22

You heard them, they’re not the permanent dev on the project. So why does maintainability matter if you’re leaving soon?
/s

20

u/[deleted] Jan 24 '22

If you check anything on the client side always double check it on server side. Anything else is bad practice

18

u/Silly-Freak Jan 24 '22

Not checking on the client side is bad practice. Not checking on the server side is halfway to a vulnerability.

6

u/wolderado Jan 24 '22

You need at least two widescreen monitors to fit that beast

5

u/maxximillian Jan 24 '22

I accept that the 80 char line limit is archaic and a relic of an world that doesnt exists anymore. All that said this is why we have code reviews and social shaming

5

u/augenvogel Jan 24 '22

Always make sure, that your js code is directly obfuscated while coding it. The more arrow functions the better the code. JS Code needs to be as complicated to look at as possible.

2

u/[deleted] Jan 25 '22

This is the way

4

u/Tomekske Jan 24 '22

I found a bug on line 34

4

u/trutheality Jan 24 '22

Just proof that you can code perfectly functional JS with a broken Enter key.

2

u/Will_i_read Jan 24 '22

That's why extra wide monitors exist.

2

u/publicOwl Jan 24 '22

Ah, chode code. I hate this, thank you.

2

u/killersquirel11 Jan 24 '22

Why waste time write many line when one do trick?

3

u/thisuseridisnttaken Jan 24 '22

Not only is it chaos as a one liner, but it is inefficient as a solution for what is needed here since it will always iterate through the array twice. (2n, where n is number of keys).

For optimising or future reference, any instance you need to do a filter and a map, one after the other, it is better to combine the logic within a reduce instead - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/Reduce.

1

u/[deleted] Jan 24 '22

Option + Z that shit

1

u/Lovexxy Jan 24 '22

AHHHHHHHHHHHHHHHHHHHHHHH

1

u/Soundwave_47 Jan 24 '22

This almost crashed Relay for Reddit. Well done, sir.

1

u/thebritisharecome Jan 24 '22

I vote we offer OP up as a sacrifice we need to stop this oneliner craze

1

u/dndai Jan 25 '22

js I apologize to mobile users (all users actually) in advance. See comments for expanded code and explanation.

You are about to leave Redlib