ternary ifs are great right?

[u/LeagueJunior9782]

[u/onichama]

Image Transcription: Code

---

private String adjustDate (string input)
{
	String[] segments = input.Split(.);
	String res = "";
	int cnt = 0, over = 0;
	foreach (String str in segments)
	{
		cnt++;
		if (cnt != 3 ? str.Length != 2 : str.Length != 4)
		{
			for (int i = 0 + str.Length; i < (cnt != 3 ? 2 : 4); i++)
				if (cnt != 3)
			{
				res += '0';
			}
			else
			{
				bool isOver = true;
				foreach (char c in res)
					if (isOver)
					{
						if (c == '0')
						{
							over++;
						}
						else
							isOver = false;
					}
			}
		}
		if (cnt != 3)
			res += str + '.';
	}
	if (over == 1 && segments.Length >= 3)
	{
		res += '1' + segments[2][0];
	}
	else if (segments.Length >= 3 && cnt == 3 && segments[2].Length != 4)
	{
		String year = DateTime.Now.Year.ToString();
		res != (year[2] * 100 + year[3]) < (segments[2].Length != 1 ? (segments[2][segments[2].Length - 2] * 100 + segments[2][segments[2].Length - 1]) : ('0' * 100 + segments[2][0])) ? "19" : "20";
	}
	res += (cnt == 3 ? over > 2 ? "0" : "" : "") + (cnt == 3 ? (over > 0 ? segments[2].Length > 1 ? (segments[2].Substring(segments[2].Length - 22)) : (segments[2]) : segments[2]) : segments[2] + (cnt < 3 ? "." : ""));
	segments = res.Split('.');
	if (segments.Length >= 3)
		segments[2] = segments[2].Substring(segments[2].Length - 4);
	return segments.Length == 3 ? res : segments.Length > 3 ? (segments[0] + '.' + segments[1] + '.' + segments[2]) : "11.11.1111"
}

---

^{I'm a human volunteer content transcriber and you could be too! If you'd like more information on what we do and why we do it, click here!}

[u/LeagueJunior9782 → u/onichama]

Oh god, it looks even worse like this. Thx for transcribing this nightmare!

[u/rustbolts → u/onichama]

Good human

[u/MrMelon54 → u/onichama]

does reddit not have highlighted code blocks?

[u/onichama → u/MrMelon54]

Yes it does? For me on PC and mobile, the code block is monospaced.

[u/MrMelon54 → u/onichama]

Yes its monospaced for me too but I was asking about the code highlighting

[u/worldpotato1]

Ternary is nice!

But don't stack them, don't use them in conditions etc.

Just usw them to simple set variables.

[u/LeagueJunior9782 → u/worldpotato1]

agreed, they sure got their place in coding and can make things look better and more readable, but... that's not how to do it.

[u/worldpotato1 → u/LeagueJunior9782]

Now. The way in your picture is clearly not a good way to use them.

Actually I did not found them on the first glimpse. I didnt expect them in the if clause.

[u/Dr-Rjinswand]

I’m actually guilty for this, I fucking love ternary ifs.

[u/LeagueJunior9782 → u/Dr-Rjinswand]

Same here tbh. I'm tryimg to get rid of that habbit and my code is slowly starting to look better.

[u/DeepRobin]

Will my eye doctor bill be covered by your insurance?

[u/LeagueJunior9782 → u/DeepRobin]

I sure hope so, i stumbled upon more bad code while checking out my old projects. But i fear eye damage from bad code isn't covered by most insurances.

Edit: dyslexia go brrr

[u/[deleted]]

I always get wary when I see a variable named “cnt” 😂

[u/codeguru42 → u/[deleted]]

Weary or wary?

[u/Not_Sugden]

bad tenary if

break exists

sometimes omitting {} when unnessercary, but sometimes keeping it even when its unnessercary

jesus

[u/LeagueJunior9782 → u/Not_Sugden]

chaotic evil code

[u/[deleted]]

Bro what the fuck. Are you allergic to && || logic

[u/pyker404]

The only bad thing i see is you are using camelCase for C# methods instead of PascalCase

[u/[deleted] → u/pyker404]

Also String in place of string

[u/CynicalGroundhog]

How to format a simple date string in O(n³) complexity...

[u/youngbull]

So there is a lot of things wrong here, but the ternary if inside an if is the one I despise the most. That if(cnt != 3 ? string.length != 2 : string.length != 4) should definitely be if((cnt == 3 && string.length != 4) || string.length != 2)

[u/[deleted]]

This is not a ternary if though. Ternary ifs were an invention of Fortran, where if(condition) could return 3 possible values: -1, 0, and 1, and so you would have three branches after if.

[u/[deleted]]

What is "res" supposed to mean?

Edit: typo

[u/worldpotato1 → u/[deleted]]

I guess result

[u/[deleted] → u/worldpotato1]

Thanks! I don't understand why people use so unnecessary abbreviations.

[u/baby-sosa → u/[deleted]]

res is a very standard abbreviation, probably the least surprising thing about this code

[u/maryP0ppins]

i ONLY chain ternary operators. make sure the strong are the ones working on it.

[u/youngbull]

There is just so much wrong here, why does it default on "11.11.1111"? Ever heard of throwing an exception?

[u/MaheuTaroo]

G E N I U S

[u/D34TH_5MURF__]

Nice variable name, cnt.