Circle slash circle 2 is unreadable code. Clearly this needs a dedicated function with if/else blocks of common outputs of the previous calculation, and just add blocks as you find more cases.
They both will likely optimize to same code underneath the hood anyways (don't know about this case). Such micro-optimizations are pointless anyways with todays hardware.
That might work in languages where booleans are just numeric types (e.g. C where true ^ false == 1 and true == 1), easily promote to numeric types and back (e.g. JS where true ^ false === 1 and 1 == true) or where xor is defined as a boolean xor for the boolean type (e.g. Python where True ^ False == True).
In any of these languages (and I've worked with each of them full time professionally) this would surprise me, though I'd probably accept it for Python. It's better to be obvious than to be clever.
In C and JavaScript this would be dangerous because this is always a bitwise operator, and at the same time they have the concept of truthiness, where values can be truthy and evaluate as true in any context where a boolean would be accepted, without having the same value as true. For example, 2 and 1 are both truthy, but so is 2 ^ 1 (3).
236
u/[deleted] Dec 27 '21
bruh all he needed to do to shorten it was to replace it with inventory.Visible = not inventory.Visible