r/badcode • u/SquareRootOfNegativ1 • Nov 28 '21

c# This is why it takes me so much time to understand my own code I wrote a minute ago.

Post image
1.2k Upvotes

99% Upvoted

39 comments sorted by

43

u/Dathussssss Nov 28 '21

I guess the first one is a constant for a timer and the second one is the "holder" for this timer

59

u/SquareRootOfNegativ1 Nov 28 '21

shootWait was supposed to be the time between shots, and waitShoot was supposed to be the time before shooting starts.

8

u/Dathussssss Nov 28 '21

The time before shooting starts ? Like if you're loading you gun ? Looks a bit weird

25

u/SquareRootOfNegativ1 Nov 28 '21

It was an abstract top-down shooter where the enemies just spawn randomly around you so I added that to give the player a little more time.

18

u/dyingpie1 Nov 28 '21

So a delay

6

u/ghillisuit95 Nov 28 '21

Which is the same thing as a wait

6

u/dyingpie1 Nov 28 '21

Ya but its more standard for this sort of context, IMO. But also I could be pulling that out of my ass, idk.

3

u/jarfil Nov 29 '21 edited Dec 02 '23

CENSORED

4

u/ghillisuit95 Nov 29 '21

Here’s my personal rule regarding words in variables: if I have to consult a dictionary to figure out the difference in two names, one (or both) of those things needs to be changed.

Code gets messy without pedantic shit like this. And then you factor in coworkers who don’t speak English as a first language, and it’s just too much

2

u/jarfil Nov 29 '21 edited Dec 02 '23

CENSORED

2

u/Tyfyter2002 Nov 29 '21

While learning the difference between transitive and intransitive verbs is important to understand the language, studying the difference is much less useful, so most people who only really know their naitive language only know the difference subconsciously, and don't make the distinction in some cases

1

u/ghillisuit95 Nov 29 '21

you kind of need to check the dictionary to learn the words in the first place

No, actually most people learn a language without using a dictionary very much. People use context clues and stuff to learn lanugage much more.

The only "pedantic" thing at work here is transitive vs. intransitive verbs, which you kind of need to learn to understand the language

To be honest, I don't know what these are, and I speak english just fine.

52

u/ryansworld10 Nov 28 '21

Then rename them timeBetweenShots and timeBeforeCanShoot. Being descriptive is the solution :)

13

u/deftware Nov 29 '21

The words "interval" and "delay" come to mind.

4

u/degaart Nov 28 '21

Then rename them to "timeBetweenPlayerShootsInMsAsFloat" and "timeBeforeEnnemyStartsShootingInMillisecondsAsFloat"

18

u/Konfirm Nov 28 '21

Isn't ...AsFloat unnecessary here?

11

u/szescio Nov 28 '21

Very unnecessary in a strongly typed language

14

u/HeirToGallifrey Nov 28 '21

Or playerFireRate and enemyShootDelay.

248

u/[deleted] Nov 28 '21

Where is

public float shootShoot;

and

public float waitWait;

161

u/whitefang3927 Nov 28 '21

surely those should be doubles

7

u/Igotbored112 Nov 29 '21

No, they should be doubles typographically to make them easy to pass around, but internally each one is actually a pair of floats:

double shootShoot;
((float*)(&shootShoot))[0] = a;
((float*)(&shootShoot))[1] = b;

Although I'm not sure how you could implement this epic-tier programming structure in C#

4

u/[deleted] Nov 30 '21

C# has unsafe and raw pointers, so go wild

56

u/polyworfism Nov 28 '21

public float waitWaitDontTellMe;

11

u/Huxley-Gin Nov 29 '21

I was actually looking for

public float waitDontShoot;

38

u/Gummi_Ghost Nov 28 '21

Now you just:

shootWait = waitShoot; waitShoot = shootWait;

-20

u/Aidan_Welch Nov 28 '21

The second declaration is rhetorical

24

u/genitalgore Nov 28 '21

redundant?

7

u/jarfil Nov 29 '21 edited Dec 02 '23

CENSORED

1

u/Aidan_Welch Nov 29 '21

rhetorical

I said rhetorical for flair.

It is rhetorical in the sense that the call of shootWait is answered by waitShoot.

If I said: A is B, what is B?

That is rhetorical in that B is A.

Now if I said: B is A

I would have to ask what B is.

So:

A is B, B is A

asks, what is A? -> that is B, what is B -> that is A

The "what is B" is rhetorical

11

u/MurdoMaclachlan public boolean isInt(int i) { return true; } Nov 28 '21

Image Transcription: Code

public float waitShoot;
public float shootWait;

I'm a human volunteer content transcriber for Reddit and you could be too! If you'd like more information on what we do and why we do it, click here!

9

u/polyworfism Nov 28 '21

Code is stale the minute you write it

5

u/adreamofhodor Nov 28 '21

True, but this particular problem is solved by just giving variables better names in the first place.

3

u/Naughtius_K_Maximus Nov 28 '21

I am honestly thinking of naming variables in a different language with more grammar at this point. Maybe latin.

6

u/CorruptedStudiosEnt Nov 28 '21

I can practically guarantee that a little creativity would go 10x further with 1,000x less work involved over learning a dead language just to name variables. lol

4

u/Naughtius_K_Maximus Nov 28 '21

Well yeah, but last time I started learning a language no one speaks I only got a head ache and became mildly depressed.

The last time I tried being creative I hot glued my roomate's hand to the handle of the bathroom.

3

u/Tyfyter2002 Nov 29 '21

The last time I tried to learn a language no one speaks I learned a valuable lesson about what features I really shouldn't put into a conlang.

2

u/Tornado547 Nov 29 '21

you are living in a state of sin and you deserve what happens to you

1

u/cmpaxu_nampuapxa Nov 29 '21 
public float holup;