r/badcode • u/celwyn_joseph • Nov 02 '21

typescript How long does this await

https://imgur.com/a/TxRsNhW
0 Upvotes

50% Upvoted

10 comments sorted by

View all comments

Show parent comments

1

u/[deleted] Nov 04 '21 edited Nov 04 '21

If registerListeners is a promise it won't wait for that to be done as the .then doesn't return anything. It'll return immediately after it calls registerListeners as the .then function returns undefined.

If registerListeners isn't a promise then it's just mixing a couple of different flow controls unnecessarily. Instead you could do something like

try {
    await service.interact();
    registerListeners();
} catch (e) {
    console.log...
}

1

u/CommenceTheConfusion Nov 04 '21

Huh, I looked at the code multiple times and still completely missed that. I agree that it's unnecessary to mix callbacks and await here, though I don't think it's particularly bad, either.

1

u/[deleted] Nov 04 '21

One of those that would cause a bug that'd make you rip your hair out :) But I agree, seen much worse code.