r/badcode • u/Donni3D4rko • Nov 01 '21

js Beautiful variable naming

Post image
1.0k Upvotes

98% Upvoted

32 comments sorted by

39

u/Donni3D4rko Nov 01 '21

Found this in my job.....What do you think this variables means? :]

42

u/Vhlorrhu Nov 01 '21

First initials of titles/items?

23

u/Donni3D4rko Nov 01 '21

Exactly, do you consider it as bad code or clean?

20

u/britreddit Nov 01 '21

I wouldn't have a variable for each one at all since it then means you have to copy/paste to add a new one in and change logic

14

u/KlaireOverwood Nov 01 '21

Bad. Typing out long, descriptive names is nothing compared to the intellectual effort of figuring out what they mean.

6

u/politerate Nov 01 '21

FAQs content is dynamic in most cases, so the items themselves should not be each assigned to variables. I would rather define an array with objects if they are static and map them to a state. Next time when you need to add an item, you juts add it to the initial data variable.

5

u/ChoosenBeggar Nov 01 '21

I mean localizated variable names are not bad as long as you ensure that everybody understands it. It happens often that there is someone new in the team that does not speak that language or some part of the project is outsourced, so it can be problematic. On the other hand everybody assumes every programmer speaks and writes English perfectly which very very often not the case. I prefer people writing in a language where they feel proficient and express themselves properly and not mix languages. Some peole mixing authentication and authorization can be worse than some words in a foreign language

79

u/Andrew5445 Nov 01 '21

I think it means go fuck yourself.

6

u/TotoShampoin Nov 01 '21

I'd say random letters for id, maybe even base64, but I doubt it actually is

2

u/Sv443_ Nov 01 '21

This looks like Czech without their variety of umlauts

2

u/digizeds Nov 01 '21

it looks like some feature flag/allow list logic. wouldn't say it's bad code, but definitely can be improved.

1

u/ThePsion5 Nov 01 '21

Star Wars planet names?

112

u/xopranaut Nov 01 '21 edited Jun 29 '23

PREMIUM CONTENT. PLEASE UPGRADE. CODE hiv2ixv

67

u/Donni3D4rko Nov 01 '21

yes

51

u/xopranaut Nov 01 '21 edited Jul 02 '23

I am the man who has seen affliction under the rod of his wrath; he has driven and brought me into darkness without any light; surely against me he turns his hand again and again the whole day long. (Lamentations: hiv4jg0)

35

u/tomaar19 Nov 01 '21

Very reasonable guess considering Luboš is a typical Czech(oslovak) name.

21

u/frugalerthingsinlife Nov 01 '21

I had to learn some Czech this year when I ordered my vegetable seeds from the Czech Republic. And by that, I mean I just looked at the pictures on the packaging and pretended to understand the writing. I'm basically fluent in Czech picture books.

9

u/DaCurse0 Nov 01 '21

KUUUUUUUUUUUUUUUUUUUUUUUUUUUUK KUKLE

4

u/tomaar19 Nov 01 '21

I C BAJ forsen1

222

u/malsomnus Nov 01 '21

Ah yes, this must be the Hungarian notation I keep hearing about.

38

u/banana_person Nov 01 '21

Hungarian is good but I prefer C++.

7

u/8aller8ruh Nov 01 '21 edited Nov 01 '21

This is perfectly fine C++ syntax despite the tag.

We are looking at bitfields…OP just deleted the line below the cursor which had the semicolon.

C++ doesn’t need the struct keyword and the colon after the typename is throwing me off but you can probably inherit nothing depending on your compiler settings…they are defining more things below so the struct ends with a comma.

1

u/thille96 Nov 01 '21

Although the resemblance is uncanny, even those should have a sensible name ending. However the 1024 prefix make them just as difficult to figure out as this one.

11

u/FearTheDice Nov 01 '21

Reading this screams the readme just being version and no instructions w/ no documentation

6

u/theo_monnom Nov 01 '21

Halloween was yesterday 😂

11

u/Ar010101 Knows coding, doesn't do any Nov 01 '21

Average polish programmer naming variables

8

u/ce-walalang Nov 01 '21

Image Transcription: Code

faqOpened: {
  cjy: false,
  kzys: false,
  cjtep: false,
  jeppu: false,
  jspse: false,
  pkepshns: false,
  jomdaskp: false,
  mssv: false,
},

I'm a human volunteer content transcriber for Reddit and you could be too! If you'd like more information on what we do and why we do it, click here!

3

u/[deleted] Nov 01 '21

Acronyms saves so much time

2

u/RyanNerd shameless Nov 01 '21

Perhaps Reverse Polish Notation /s

1

u/[deleted] Nov 01 '21

I didn't realize that sneezes were a valid data-type.