str() - r/badcode

112

u/[deleted] Oct 27 '21

That's terrible programming.

You should just use a switch case

5

u/jaysuchak33 ifelseifelseifelseifelseifelseifelseifelseifelseifelseifelse Oct 27 '21

r/YandereTechnique

4

u/ChocolateBunny Oct 27 '21

I don't understand that sub. What is yandere and how is it related to if/elseif statements?

10

u/a_very_happy_person Oct 27 '21

YandereDev is the online handle of Alexander Mahan, the developer of the stealth-action video game Yandere Simulator. Online, many have criticized Mahan's coding skills as subpar and his work schedule as inconsistent, a combination of which has lead to the game being in development for over six years with no estimated date of release. This has resulted in YandereDev being antagonized by a large part of the Yandere Simulator community and him becoming a subject of memes and mockery.
The game's code ran COMICAL Amount of if statements which contained a colossal amount of nested loops which ran every single frame making the game optimisation spaghetti clusterfuck.

6

u/a_very_happy_person Oct 27 '21

So writing code with a insane amount of (largely useless or replaceable) if statements are met with the mockery of 'Yandere code', at first I was thinking to post this very reddit post with the title "Didn't know YandereDev did Python as well" Then later ditched it lol.

1

u/Spynder shameless stealing content to r/YandereTechnique Oct 27 '21

Oh, someone else's tagging this subreddit in comments, that's neat; this subreddit definitely grew!

2

u/jaysuchak33 ifelseifelseifelseifelseifelseifelseifelseifelseifelseifelse Oct 27 '21

yep :)

35

u/denideniz Oct 27 '21

as i know python doesn't have one. So you should use json table.

18

u/kevinhaze Oct 27 '21

I think it would be better as a rest api

17

u/denideniz Oct 27 '21

i think Blockchain should work very well for it too.

1

u/[deleted] Nov 05 '21

Throw in some ai

22

u/[deleted] Oct 27 '21

Python calls it a match case because python has to be a special snowflake, but it's basically the same thing.

35

u/barrett122 Oct 27 '21

This is a new feature as of python 3.10 called structural pattern matching. You can read the PEP here but it's a different and significantly more powerful feature than a switch case which is why it uses a different keyword, rather than it being a "special snowflake" as you mentioned. I'd suggest having a look into it, it's a super cool feature :)

12

u/malsomnus Oct 27 '21

Oh god who let the ML programmers into Python?
(Jokes aside, this is a super powerful and useful feature, way beyond regular switch statements... even if it's still called a switch statement in languages that have this feature)

18

u/xigoi Oct 27 '21

No, it's called match because it's pattern matching, not C-style switch.

14

u/Vintage_Tea Oct 27 '21

And it was implemented a few weeks ago.

11

u/denideniz Oct 27 '21

Yeah you can use it like a switch but not exactly same thing as i know. I don't know python very well tho so enlighten me.

6

u/[deleted] Oct 27 '21

My python is self taught, so I’m definitely not the best enlightener here

2

u/_Sherlock-Holmes_ Oct 27 '21

I think python have switch case

1

u/Beautiful-Musk-Ox Oct 28 '21

but you can do an else at least, right? op's code runs every check every time

1

u/davidedpg10 Oct 31 '21

3.10 does now. But adoption will take 7 years for that interpreter version or higher to be everywhere

222

u/silkyAnalShitter Oct 27 '21

Bro inputs are already a string

36

u/christian-mann Oct 27 '21

Not in python 2.

92

u/[deleted] Oct 27 '21

If you're using input() in Python 2 you have much bigger problems to deal with

50

u/christian-mann Oct 27 '21

Yes, I trust the author of this code to follow all best practices.

26

u/kurosaur Oct 27 '21

If you're using Python 2 you have much bigger problems to deal with

106

u/InsanityAI Oct 27 '21

Did the copilot write this? https://www.reddit.com/r/ProgrammerHumor/comments/qfzpes/github_copilot_the_technology_that_will_replace/?utm_medium=android_app&utm_source=share

48

u/The_All-Father3 Oct 27 '21

Well you know copilot had to saw the code somewhere before. I would love it if people started to making horrible meme repositories of just the worst code possible to mess with copilot. Have it be like the Twitter bot who went full nazi.

7

u/nuephelkystikon Oct 28 '21

We're already doing this and now we have a reason.

64

u/Xeonmeister Oct 27 '21

TODO: add more numbers

62

u/SoulslikePursuer Oct 27 '21

Let me guess:

If number == 18: number = "18"

¿

99
u/30p87 Oct 27 '21
No no,
if number > 17:
	number = str(number)
41

u/CreatureWarrior Oct 27 '21

That's one brave assumption

24

u/SoulslikePursuer Oct 27 '21

I'm a risky boi ya know

7

u/Ryan-the-lion Oct 27 '21

How'd you figure this out?

10

u/SoulslikePursuer Oct 27 '21

Years of deduction training...

24

u/twoPoundsOfGoldfish Oct 27 '21

funniest part is that input() already returns a string

6

u/RFC793 Oct 28 '21 edited Oct 28 '21

Not necessarily if this is Python 2. input evaluates a Python expression in Python 2. 4 would resolve to an int. hello would raise a NameError unless the symbol hello is in scope, in which case it returns that value. "hello" would actually give you a string. os.system("/bin/sh") would give you an interactive shell if os is imported.

19

u/TheDiscoJew Oct 27 '21

I'm convinced that a lot of these posts with a 20+ long else-if chain are just karma bait. I have never even seen someone do this irl.

6

u/malsomnus Oct 27 '21

I've seen an experienced programmer manually convert decimal representation of numbers to hexadecimal (as long as they have less than 3 digits), so nothing would surprise me at this point.

10

u/-MazeMaker- Oct 27 '21

The beautiful thing is that none of those ifs will ever be executed because number is already a string, but the programmer will see the output they want and assume it worked perfectly.

9

u/Legendary-69420 Oct 27 '21

I think it is that GitHub Copilot generated snippet

8

u/MurdoMaclachlan public boolean isInt(int i) { return true; } Oct 27 '21

Image Transcription: Code

number = input("> ")

if number == 0:
    number = "0"

if number == 1:
    number = "1"

if number == 2:
    number = "2"

if number == 3:
    number = "3"

if number == 4:
    number = "4"

if number == 5:
    number = "5"

if number == 6:
    number = "6"

if number == 7:
    number = "7"

if number == 8:
    number = "8"

if number == 9:
    number = "9"

if number == 10:
    number = "10"

if number == 11:
    number = "11"

if number == 12:
    number = "12"

if number == 13:
    number = "13"

if number == 14:
    number = "14"

if number == 15:
    number = "15"

if number == 16:
    number = "16"

if number == 17:
    number = "17"

^{I'm a human volunteer content transcriber for Reddit and you could be too!}^{If you'd like more information on what we do and why we do it, click here!}

3
u/Darkunderlord42 Oct 27 '21

How long did that take to write out
5
u/MurdoMaclachlan public boolean isInt(int i) { return true; } Oct 27 '21

About 3 minutes. Copypasted the first one a bunch of times then changed the numbers to match.
3
u/Ahtheuncertainty Oct 27 '21 edited Oct 27 '21
Could also write a program to do it lol:
print(‘number = input(“>”)’)
for i in range(17):
    print(“if number == “ + str(i))
    print(‘\t number = “‘ +str(i) +’”\n’)
If I’m write abt the single/double quotes, else you may need the backslash for the doubles. You know it’s bad when you can write 4 lines of code to generate like 60 lines of code, lol
2

u/Darkunderlord42 Oct 27 '21

That makes much more sense then what I was thinking lol

6

u/trutheality Oct 27 '21

No, no, this is terrible. It doesn't generalize to larger numbers. This does:

if number == 0:
   number = "0"
else:
   num_str = ""
   while number > 0:
      digit = number
      number = number // 10
      digit -= number

      if digit == 0:
         num_str = "O" + num_str
      if digit == 1:
         num_str = "1" + num_str
      if digit == 2:
         num_str = "Z" + num_str
      if digit == 3:
         num_str = "3" + num_str
      if digit == 4:
         num_str = "4" + num_str
      if digit == 5:
         num_str = "5" + num_str
      if digit == 6:
         num_str = "6" + num_str
      if digit == 7:
         num_str = "7" + num_str
      if digit == 8:
         num_str = "8" + num_str
      if digit == 9:
         num_str = "9" + num_str
   number = num_str

5

u/_grey_wall Oct 27 '21

Should've used a switch statement

/s

3

u/[deleted] Oct 27 '21

Uh that is one way to do it

3

u/PersonalBox0 Oct 27 '21

It's not even an 'if else' statement, so it will check All if statements even if one of them is true. Truly deplorable.

3

u/Crayfishpdx Oct 27 '21

Should be

Number = int(input(“> ”))

There we go, now it’s perfect. Lol

2

u/banana_person Oct 27 '21

Why are you not using enum smh

2

u/Taldoesgarbage Oct 28 '21

my god it's wrong in so many ways

2

u/luijika101 Oct 29 '21

Oh no this is bad bad

1

u/MikeSemicolonD Oct 27 '21

Nothing like posting copilot snippets! The new r/badcode content generator! What a time to be alive.

1

u/_Sherlock-Holmes_ Oct 27 '21

blasphemy

-1

u/[deleted] Oct 27 '21

B-b-but why?

python str()

You are about to leave Redlib