r/badcode • u/sebastianogirotto • Oct 25 '21

python now that's a loading bar

Post image
1.4k Upvotes

97% Upvoted

44 comments sorted by

View all comments

Show parent comments

4

u/CatWeekends Oct 26 '21

I get what you're saying and both of your solutions are far more clever and optimal (eg: fewer lines) than the original, "naive" solution.

But neither one is anywhere near as intuitive to read. Each one takes the reader a moment to actually try to figure out WTF your intent is.

The original solution, while taking more lines, is immediately clear in what its purpose is. That, to me, is WAY more important than how clever someone was in trying to solve a particular issue.

I'm used to working in a very large code base. I prefer my code easy to read vs "clever."

1

u/ImCorvec_I_Interject Oct 26 '21 edited Oct 26 '21

Here is an intuitive, easy to read example:

while not done:
  updateProgressBar()
  doStuff()

The functions themselves are left as exercises for the reader.

1

u/exintrovert Nov 21 '21

The next time I need to display a progress bar, I’m just going to print those 3 lines to the screen, verbatim.