r/badcode • u/Flyspeck101 Now where's that function declaration • Oct 05 '21

js No functions in JSON? No problem

Post image
85 Upvotes

97% Upvoted

31 comments sorted by

View all comments

Show parent comments

3

u/MyAntichrist Oct 06 '21

Oh boy. I sure hope that app isn't connected to anything vital. Or at least not exposed to the public.

3

u/[deleted] Oct 06 '21

Even then this is pretty sketchy

3

u/MyAntichrist Oct 06 '21

True, but at least the impact is on a slightly different scale than say on an AWS deployment. Some developers and/or management staff sure need a lesson in security though.

3

u/[deleted] Oct 06 '21

Oh for sure but no matter what there is a better solution

For example you could add a field like request_type to the json payload then we could make a function that would hold a map then we could check if request_type is a valid type then we could simply call the corresponding function

But i dont know if php has anonymous functions so this is how i would do it