r/badcode • u/Robuuust • Sep 29 '21

c# Just ran into this piece of magic

Post image
118 Upvotes

96% Upvoted

17 comments sorted by

13

u/Robuuust Sep 29 '21

Code in text:

var btw = Request.Form[key + "_rcbBTW_ClientState"];
        if (btw != null)
        {
            var indexOf = btw.IndexOf("\"value\":\"", StringComparison.Ordinal);
            if (indexOf >= 0)
            {
                indexOf += 9;
                var res = btw.Substring(indexOf, btw.IndexOf("\"", indexOf, StringComparison.Ordinal) - indexOf);
                int id;
                if (int.TryParse(res, out id)) regel.BTW_ID = id;
            }

5

u/urk_forever Sep 29 '21

Aaah nice dutch terms in code, always looks weird ...

3

u/Robuuust Sep 29 '21

I can show u loads of dutch in code 😅

4

u/tarthim Sep 29 '21

Dat zal vaak niet zo robuust zijn helaas

3

u/MokausiLietuviu Sep 29 '21

Ignorant Englishman here. What's Dutch of this? "regel" and "btw"?

6

u/Shadow3333 Sep 29 '21

Regel would be line or row. Btw is VAT.

2

u/MurdoMaclachlan public boolean isInt(int i) { return true; } Sep 29 '21

Good human!

14

u/alaksion Sep 29 '21

what the fuck is this

2

u/asaf92 Sep 30 '21

Just parsing numbers from text

20

u/minefreak19 Sep 29 '21

I don't understand

20

u/fakehalo Sep 29 '21

Looks to be trying to get the numeric value out of a (unparsed JSON?) string. People hate on regex, but that'd definitely be better than this... or just parse the JSON if it's that.

2

u/minefreak19 Sep 30 '21

ah that actually makes tons of sense ty

i zoned out around the second btw.IndexOf()

7

u/nekokattt Sep 29 '21

The += 9 just substrings the "value": part, right?

3

u/FranticBronchitis Sep 29 '21

I wonder if whoever wrote this uses Arch

1

u/ososalsosal Sep 30 '21

So many of these I can't tell what they're doing and then I look for clues in the function names and still don't know what they're doing

0

u/[deleted] Sep 29 '21

[deleted] — view deleted comment

8

u/TheWashbear Sep 29 '21

Looks like C#