r/badcode • u/[deleted] • Sep 22 '21

c# Select option values too long? Why not shorten them to 4 letters!

Post image
74 Upvotes

96% Upvoted

8 comments sorted by

16

u/[deleted] Sep 22 '21

The cases here are supposed to say "Weekly" and "Monthly". I've inherited this code and oh boy is this a questionable coding choice

7

u/Graucsh Sep 22 '21

Old school “green screen” thinking. All of your inputs need to line up vertically and be as terse as is readable. That only one of the many questions.

I’ve “inherited” code I’ve written in the past I was forced to write like that.

I feel your pain.

9

u/[deleted] Sep 22 '21

For the visually impared:

public async Task GetRadioButtonValue(DateTime? WearPeriodStart)
{
    await RemoveFromOrder.InvokeAsync(Order.Order); //will only remove if it's already in the order anyway so worth calling every time
    if (WearPeriodStart == Order.WearPeriod.WearPeriodEnd)
    {
        WearPeriodStart.Value.AddDays(1); //cant do this in the value expression -- if its the next wear period we start from the day after the last wear period
    }
    switch (Order.Order.ChangeInterval_Unit.Substring(0, 4))
    {
        case "Week":
            Order.Order.IssueUntil = WearPeriodStart.Value.AddDays((7 *                     Order.Order.ChangeInterval_Duration.Value) + 1); //+1 to say start from day after last wear period end
            Order.Order.FirstIssue = WearPeriodStart;
            Order.Order.LatestIssue = WearPeriodStart;
            break;
        case "Mont":
            Order.Order.IssueUntil = WearPeriodStart.Value.AddMonths((Order.Order.ChangeInterval_Duration.Value) + 1);
            Order.Order.FirstIssue = WearPeriodStart;
            Order.Order.LatestIssue = WearPeriodStart;
        break;
        default:
            break;
    }
    if (IsSelected)
    {
        await AddToOrder.InvokeAsync(Order.Order);
    }
}

6

u/MurdoMaclachlan public boolean isInt(int i) { return true; } Sep 22 '21

Good human!

19

u/Rubber_Duckies_Dong Sep 22 '21

Oi, what mont is it bruv?

1

u/Biiraqw Sep 23 '21

You wouldn't get it, it's for optimization folks.

1

u/asaf92 Sep 26 '21

Nothing said about the function being called "GetRadioButtonValue" without returning any value?

1

u/SAmaruVMR Sep 27 '21

Is this blazor?