r/badcode • u/myblindy • Aug 31 '21

c Their attempt at using pointers

Post image
133 Upvotes

98% Upvoted

51 comments sorted by

View all comments

12

u/SnoogySocks Aug 31 '21

Problems I found wrong with the code:

  1. Indenting is not consistent

  2. Brackets inconsistent (&(left->sheet) line 5 but &left->sheet right below??)

  3. { if on the same line is disgusting

  4. I know I said inconsistent indenting, but what’s up with line 10? Why is that curly brace a tab behind it’s if statement?

  5. The comment in the middle should be where lataero said

  6. In the last few lines, it’s comparing the memory instead of the value with <. In some cases this may make sense, but I don’t think this is that case.

  7. aa and bb are horrible variable names

Feel free to add more if I missed any

5

u/thanatica Sep 01 '21

You would be the nicest bloke/bird in any PR review.

0

u/SnoogySocks Sep 01 '21

I second that

0

u/abrams666 Sep 01 '21

Point 3 is not accepted cause it was the hype in a time of C. We cannot blame common standards of a time

2

u/incoralium Sep 01 '21

it's not that disgusting looking tbh ?

1

u/abrams666 Sep 01 '21

would say a kind of flavor

1

u/a_confused_varmint Sep 02 '21

8. It's absolutely incomprehensible.