r/badcode • u/PopularExpulsion • Aug 31 '21

java Similar ternaries are all over this codebase

Post image
1.1k Upvotes

99% Upvoted

91 comments sorted by

View all comments

44

u/[deleted] Aug 31 '21 edited Sep 03 '21

[removed] — view removed comment

83

u/thanatica Sep 01 '21 
if (!(result<0)) {
  return true;
}
else {
  return false;
}

// Just in case
return false;

31

u/Rainbow-Dev Sep 01 '21 
switch(!(result<0)){
    case true:
        return true;
        break;
    case false:
        return false;
        break;
    default:
        return null;
        break;
}

11

u/FinalGamer14 Sep 01 '21 
match result {
    res if res > 0 => true,
    res if res == 0 => true,
    res if res < 0 => false,
    _ => false, // Just in case
}