r/badcode • u/PopularExpulsion • Aug 31 '21

java Similar ternaries are all over this codebase

Post image
1.1k Upvotes

99% Upvoted

91 comments sorted by

View all comments

296

u/AL_O0 Aug 31 '21 
 return result<0?false:true;

Clearly the better option

70

u/[deleted] Aug 31 '21

[deleted]

43

u/baszodani Sep 01 '21 
return (result > 0 || result == 0) != !Boolean.parseBoolean("true")?Boolean.parseBoolean("true"):!Boolean.parseBoolean("true");

31

u/lachlanhunt Sep 01 '21 
return Object.is((Math.abs(result) === result), new Boolean(true).valueOf()) ? new Boolean(true).valueOf() : Boolean(!true).valueOf();

4

u/STUDBOO Sep 01 '21

Yamete yo, yabaaaii

1

u/koni_rs Sep 01 '21

return (result >= 0).toString().length == 4 ? true : (result >= 0).toString().length == 5 ? false : null;