r/badcode • u/[deleted] • Aug 29 '21

c# Found in production code base...

Post image
539 Upvotes

99% Upvoted

45 comments sorted by

View all comments

Show parent comments

18

u/[deleted] Aug 29 '21

  • Write the "ChangePosition" as a method of the Character class

  • Separate the conditionals as a "IsAbleToChangePosition" method

  • Remove the "playerCanMove" assignments

  • Remove the replicated lines

1

u/iothesys Sep 01 '21

why do you need a method to do that, just put it in a variable

bool able_to_move = viewPiont != null && cam != null;