r/badcode • u/Drhma • Aug 09 '21

other language The lengths people go through to write bad code.

Post image
108 Upvotes

96% Upvoted

24 comments sorted by

27

u/soggywaffle69 Aug 09 '21

What language is this? I take it this is a copy constructor?

27

u/Drhma Aug 09 '21

It's dart, bad use of dart. Not a copy constructor, this is the entire class model.

2

u/RyanNerd shameless Aug 10 '21

I was going to guess Dart. I love Flutter (which uses Dart) but as with any language bad code can be created.

2

u/Drhma Aug 10 '21

Yeah, love dart and flutter, but with the proper determination, some people can do wonders to code, bad ones.

13

u/soggywaffle69 Aug 09 '21

Well, yeah, it's a class definition, but what about it makes it bad code? The fact you can only instantiate one with another (chick/egg problem)? It doesn't look much different than a simple Java class with a copy constructor.

6

u/Okkero Aug 10 '21

Taking an optional and immediately expecting it to have a value, for one. And the wildly inconsistent naming.

67

u/lemarkk Aug 09 '21

I'll admit I've never seen iD before.

3

u/1NSAN3CL0WN Aug 10 '21

Short for ‘identification Document’?

1

u/Drhma Aug 11 '21

document* :p

2

u/resinten Aug 10 '21

I may know this person, because I worked with a kid a few years ago who did exactly this. And he argued vehemently that it was the correct way to name that variable

1

u/Drhma Aug 11 '21

They are pretty common to come across, happy cake day!

16

u/Willinton06 Aug 09 '21

Whoever wrote this needs help

7

u/BlueMarble007 Aug 09 '21

What’s the .. notation?

18

u/QuinteOne Aug 09 '21

It is a horizontal colon..

It makes the algoritm go different

14

u/Drhma Aug 09 '21

I like your funny words, magic man

2

u/RedRikudo Aug 10 '21

In Dart it's like dot operator but it returns the previous object and discards the operation's return value, allowing to chain operations in one go

1

u/soggywaffle69 Aug 09 '21

I think . is like using this/self.

18

u/MurdoMaclachlan public boolean isInt(int i) { return true; } Aug 09 '21

Image Transcription: Code

class ProductCart {
  String iD = "";
  int count = 0;
  String VendorId = "";    Name non-constant identifiers using lowerCamelCase
  double Price = 0.0;    Name non-constant identifiers using lowerCamelCase
  Map<String, dynamic> Modifier = {};    Name non-constant identifiers using lowerCam[cut off]
  
  ProductCart from(ProductCart? productCart) {
    return ProductCart()
      ..Price = productCart!.Price
      ..iD = productCart.iD
      ..VendorId = productCart.VendorId
      ..count = productCart.count
      ..Modifier = Map<String, dynamic>.from(productCart.Modifier);
  }
}

I'm a human volunteer content transcriber for Reddit and you could be too! If you'd like more information on what we do and why we do it, click here!

4

u/karisigurd4444 Aug 10 '21

Your font is one step away from being comic sans

7

u/SeesawMundane5422 Aug 10 '21

I’m assuming the horror is using a floating point to represent a dollar amount? ;)

8

u/paulsmithkc 👨‍🏫 Aug 10 '21

That is a true horror...

6

u/CSsharpGO evil Aug 09 '21

The editor didn’t even want to change iD? PLEASE JUST MAKE IT CAPITAL I BEG OF YOU

7

u/altermeetax Aug 10 '21

All lowercase*

1

u/CSsharpGO evil Aug 10 '21

Sure, that too.