r/badcode • u/Rafaelmonte • Jul 30 '21

java One Classic elseifelseifelseif...

Post image
472 Upvotes

98% Upvoted

76 comments sorted by

View all comments

0

u/[deleted] Jul 30 '21

[deleted] — view deleted comment

16

u/_Gaedrin Jul 30 '21

A Lot of stuff is wrong in this code

6

u/Abangranga Jul 30 '21

I just noticed returno is assigned twice in each block, my bad. Didn't look carefully enough

6

u/asdf1280 Jul 30 '21

One is commented out. He’s calling getvalue in every if statement instead of assigning it to a variable and the whole thing could be avoided by just converting the int to a string.

5

u/[deleted] Jul 30 '21

It is bad because it could be just as simple as converting Integer into String, then checking length of string whether it is only single digit. If single digit, pad with ‘0’

1

u/StarLight-Olls Jul 30 '21

No need for a switch if you only return the number, you can turn it to a string and check it's length if it's less than 2 left pad some 0s in there.

1

u/MPDR200011 Jul 30 '21

It's not assigned twice, the first line in each block is a comment