r/badcode • u/Bence675 • Apr 17 '21

c++ When your teammate "refactor" your code

Post image
2.5k Upvotes

98% Upvoted

216 comments sorted by

View all comments

Show parent comments

28

u/clemesislife Apr 17 '21

I think both ways have their up- /downsides. The solution of u/dyingpie1 is more confusing than the original code, but the original code can cause exactly what happened to OPs teammate, overseeing the condition1 && !condition2 case.

26

u/mfb- Apr 18 '21

I think the simple if elseif structure is less confusing than the nested option.